fix: do not fix when there are parent conflicts

Author: 43081j

packages/eslint-plugin-svelte/src/rules/derived-has-same-inputs-outputs.ts

@@ -15,16 +15,25 @@ function findVariableForName(
 	let hasConflict = false;
 	let variable: Variable | null = null;
 
-	for (const v of scope.variables) {
-		if (hasConflict && variable) {
-			break;
-		}
-		if (v.name === expectedName) {
+	for (const ref of scope.references) {
+		if (ref.identifier.name === expectedName) {
 			hasConflict = true;
-			continue;
+			break;
 		}
-		if (v.name === name) {
-			variable = v;
+	}
+
+	if (!hasConflict) {
+		for (const v of scope.variables) {
+			if (hasConflict && variable) {
+				break;
+			}
+			if (v.name === expectedName) {
+				hasConflict = true;
+				continue;
+			}
+			if (v.name === name) {
+				variable = v;
+			}
 		}
 	}
 

packages/eslint-plugin-svelte/tests/fixtures/rules/derived-has-same-inputs-outputs/invalid/test01-errors.yaml

@@ -66,6 +66,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$c'.
   line: 6
   column: 13
@@ -134,6 +140,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$e'.
   line: 9
   column: 19
@@ -202,6 +214,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$f'.
   line: 9
   column: 22
@@ -270,6 +288,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$i'.
   line: 12
   column: 19
@@ -338,6 +362,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$j'.
   line: 12
   column: 22
@@ -406,6 +436,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$l'.
   line: 15
   column: 26
@@ -474,6 +510,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$o'.
   line: 18
   column: 22
@@ -542,6 +584,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$a'.
   line: 21
   column: 13
@@ -610,6 +658,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$a'.
   line: 28
   column: 13
@@ -678,6 +732,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$e'.
   line: 37
   column: 19
@@ -746,6 +806,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$f'.
   line: 37
   column: 22
@@ -814,6 +880,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$e'.
   line: 46
   column: 19
@@ -882,6 +954,12 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$f'.
   line: 46
   column: 22
@@ -950,7 +1028,17 @@
         	const $a = 303;
         	$a;
         });
+        somethingWithACallback(() => {
+        	const $a = 303;
+        	derived(a, (b) => {
+        		$a;
+        	});
+        });
 - message: The argument name should be '$a'.
   line: 57
   column: 13
   suggestions: null
+- message: The argument name should be '$a'.
+  line: 64
+  column: 14
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/derived-has-same-inputs-outputs/invalid/test01-input.js

@@ -59,3 +59,9 @@ derived(a, (b) => {
 	const $a = 303;
 	$a;
 });
+somethingWithACallback(() => {
+	const $a = 303;
+	derived(a, (b) => {
+		$a;
+	});
+});