chore: don't select devtools-json by default (#605)

* dont select devtools-json by default

* Create brown-peas-shop.md

---------

Co-authored-by: Manuel <[email protected]>

Author: Rich-Harris

.changeset/brown-peas-shop.md

@@ -0,0 +1,5 @@
+---
+"sv": patch
+---
+
+chore: don't select `devtools-json` by default

packages/addons/devtools-json/index.ts

@@ -8,13 +8,6 @@ export default defineAddon({
 	homepage: 'https://github.com/ChromeDevTools/vite-plugin-devtools-json',
 	options: {},
 
-	setup: ({ defaultSelection }) => {
-		defaultSelection({
-			create: true,
-			add: false
-		});
-	},
-
 	run: ({ sv, typescript }) => {
 		const ext = typescript ? 'ts' : 'js';
 

packages/cli/commands/add/index.ts

@@ -201,16 +201,15 @@ export const add = new Command('add')
 
 		common.runCommand(async () => {
 			const selectedAddonIds = selectedAddons.map(({ id }) => id);
-			const { nextSteps } = await runAddCommand(options, selectedAddonIds, 'add');
+			const { nextSteps } = await runAddCommand(options, selectedAddonIds);
 			if (nextSteps) p.note(nextSteps, 'Next steps', { format: (line: string) => line });
 		});
 	});
 
 type SelectedAddon = { type: 'official' | 'community'; addon: AddonWithoutExplicitArgs };
 export async function runAddCommand(
 	options: Options,
-	selectedAddonIds: string[],
-	from: 'create' | 'add'
+	selectedAddonIds: string[]
 ): Promise<{ nextSteps?: string; packageManager?: AgentName | null }> {
 	const selectedAddons: SelectedAddon[] = selectedAddonIds.map((id) => ({
 		type: 'official',
@@ -391,11 +390,6 @@ export async function runAddCommand(
 	const setups = selectedAddons.length ? selectedAddons.map(({ addon }) => addon) : officialAddons;
 	const addonSetupResults = setupAddons(setups, workspace);
 
-	// get all addons that have been marked to be preselected
-	const initialValues = Object.entries(addonSetupResults)
-		.filter(([_, value]) => value.defaultSelection[from] === true)
-		.map(([key]) => key);
-
 	// prompt which addons to apply
 	if (selectedAddons.length === 0) {
 		const addonOptions = officialAddons
@@ -410,8 +404,7 @@ export async function runAddCommand(
 		const selected = await p.multiselect({
 			message: `What would you like to add to your project? ${pc.dim('(use arrow keys / space bar)')}`,
 			options: addonOptions,
-			required: false,
-			initialValues
+			required: false
 		});
 		if (p.isCancel(selected)) {
 			p.cancel('Operation cancelled.');

packages/cli/commands/create.ts

@@ -184,8 +184,7 @@ async function createProject(cwd: ProjectPath, options: Options) {
 				community: [],
 				addons: {}
 			},
-			[],
-			'create'
+			[]
 		);
 		packageManager = pm;
 		addOnNextSteps = nextSteps;

packages/cli/lib/install.ts

@@ -90,8 +90,7 @@ export function setupAddons(
 		const setupResult: AddonSetupResult = {
 			unsupported: [],
 			dependsOn: [],
-			runsAfter: [],
-			defaultSelection: { create: false, add: false }
+			runsAfter: []
 		};
 		addon.setup?.({
 			...workspace,
@@ -100,10 +99,7 @@ export function setupAddons(
 				setupResult.runsAfter.push(name);
 			},
 			unsupported: (reason) => setupResult.unsupported.push(reason),
-			runsAfter: (name) => setupResult.runsAfter.push(name),
-			defaultSelection: (defaultSelection) => {
-				setupResult.defaultSelection = defaultSelection;
-			}
+			runsAfter: (name) => setupResult.runsAfter.push(name)
 		});
 		addonSetupResults[addon.id] = setupResult;
 	}

packages/core/addon/config.ts

@@ -38,7 +38,6 @@ export type Addon<Args extends OptionDefinition> = {
 			dependsOn: (name: string) => void;
 			unsupported: (reason: string) => void;
 			runsAfter: (addonName: string) => void;
-			defaultSelection: (args: { create: boolean; add: boolean }) => void;
 		}
 	) => MaybePromise<void>;
 	run: (workspace: Workspace<Args> & { sv: SvApi }) => MaybePromise<void>;
@@ -61,12 +60,7 @@ export function defineAddon<Args extends OptionDefinition>(config: Addon<Args>):
 	return config;
 }
 
-export type AddonSetupResult = {
-	dependsOn: string[];
-	unsupported: string[];
-	runsAfter: string[];
-	defaultSelection: { create: boolean; add: boolean };
-};
+export type AddonSetupResult = { dependsOn: string[]; unsupported: string[]; runsAfter: string[] };
 
 export type AddonWithoutExplicitArgs = Addon<Record<string, Question>>;
 export type AddonConfigWithoutExplicitArgs = Addon<Record<string, Question>>;