triedb/pathdb: sync ancient store before journal (ethereum#32557) (ethereum#718)

This pull request addresses the corrupted path database with log
indicating:
`history head truncation out of range, tail: 122557, head: 212208,
target: 212557`

This is a rare edge case where the in-memory layers, including the write
buffer
in the disk layer, are fully persisted (e.g., written to file), but the
state history
freezer is not properly closed (e.g., Geth is terminated after
journaling but
before freezer.Close). In this situation, the recent state history
writes will be
truncated on the next startup, while the in-memory layers resolve
correctly.
As a result, the state history falls behind the disk layer (including
the write buffer).

In this pull request, the state history freezer is always synced before
journal,
ensuring the state history writes are always persisted before the
others.

Edit: 
It's confirmed that devops team has 10s container termination setting.
It
explains why Geth didn't finish the entire termination without state
history
being closed.

https://github.com/ethpandaops/fusaka-devnets/pull/63/files

Co-authored-by: rjl493456442 <[email protected]>

Author: joshklop

triedb/pathdb/journal.go

@@ -333,7 +333,16 @@ func (db *Database) Journal(root common.Hash) error {
 	if db.readOnly {
 		return errDatabaseReadOnly
 	}
-
+	// Forcibly sync the ancient store before persisting the in-memory layers.
+	// This prevents an edge case where the in-memory layers are persisted
+	// but the ancient store is not properly closed, resulting in recent writes
+	// being lost. After a restart, the ancient store would then be misaligned
+	// with the disk layer, causing data corruption.
+	if db.stateFreezer != nil {
+		if err := db.stateFreezer.SyncAncient(); err != nil {
+			return err
+		}
+	}
 	// Store the journal into the database and return
 	var (
 		file        *os.File