From e7efa6776b5c8943e9d225b3ee701b75fb70947b Mon Sep 17 00:00:00 2001 From: Mackenzie Zastrow Date: Thu, 5 Jun 2025 16:09:26 -0400 Subject: [PATCH 1/2] fix: ignore mypy error from latest OpenTelemetrySDK update See open-telemetry/opentelemetry-python#4615 but it looks like an OpenTelemetrySDK update caused type errors --- src/strands/telemetry/tracer.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/strands/telemetry/tracer.py b/src/strands/telemetry/tracer.py index 34eb7bed8..211419b9c 100644 --- a/src/strands/telemetry/tracer.py +++ b/src/strands/telemetry/tracer.py @@ -13,7 +13,9 @@ from opentelemetry import trace from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter -from opentelemetry.sdk.resources import Resource + +# See see https://github.com/open-telemetry/opentelemetry-python/issues/4615 for the type ignore +from opentelemetry.sdk.resources import Resource # type: ignore[attr-defined] from opentelemetry.sdk.trace import TracerProvider from opentelemetry.sdk.trace.export import BatchSpanProcessor, ConsoleSpanExporter, SimpleSpanProcessor from opentelemetry.trace import StatusCode From 3424d2b96c245ecbe3ef9beba35d2f6425aa5877 Mon Sep 17 00:00:00 2001 From: Mackenzie Zastrow <3211021+zastrowm@users.noreply.github.com> Date: Thu, 5 Jun 2025 16:12:36 -0400 Subject: [PATCH 2/2] Update tracer.py --- src/strands/telemetry/tracer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/strands/telemetry/tracer.py b/src/strands/telemetry/tracer.py index 211419b9c..9f731996e 100644 --- a/src/strands/telemetry/tracer.py +++ b/src/strands/telemetry/tracer.py @@ -14,7 +14,7 @@ from opentelemetry import trace from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter -# See see https://github.com/open-telemetry/opentelemetry-python/issues/4615 for the type ignore +# See https://github.com/open-telemetry/opentelemetry-python/issues/4615 for the type ignore from opentelemetry.sdk.resources import Resource # type: ignore[attr-defined] from opentelemetry.sdk.trace import TracerProvider from opentelemetry.sdk.trace.export import BatchSpanProcessor, ConsoleSpanExporter, SimpleSpanProcessor