Skip to content

Conversation

@dbschmigelski
Copy link
Member

@dbschmigelski dbschmigelski commented Oct 23, 2025

Description

Add PR Size Labeler to Improve Review Velocity
PRs have been taking longer to review because they are not scoped to manageable sizes. Large PRs create review bottlenecks where reviewers struggle to provide thorough feedback and risk missing critical issues in complex changes. This change encourages smaller, focused PRs that are easier to review and helps reviewers prioritize their time. Blocks oversized PRs that should be split, improving overall development velocity through faster review cycles.

Solution

Adds an automated GitHub Action that labels pull requests based on their size:

size/xs: ≤20 lines

size/s: ≤100 lines

size/m: ≤500 lines

size/l: ≤1000 lines

size/xl: >1000 lines (fails the check)

This change only runs for trusted assignees. We can loosen this in the future. But the reason is that maintainers should only be running "Approve workflows" if they have already reviewed the PR. So if you have already reviewed the PR this is not that useful of a feature.

Type of Change

CI

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Tested in dbschmigelski/integ-testing where PRs of multiple sizes were executed against it.

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dbschmigelski
Copy link
Member Author

dbschmigelski commented Oct 23, 2025

Updated, also fixed the logical bug to force the labeler to first remove existing size labels.

Appears we are failing because of a permissions issue that is not appearing in the personal account testing - "Resource not accessible by integration"

Unsure why this PR is even running since its not on main.


Edit: silly mistake, needed pull_request_target, not pull_request

@dbschmigelski dbschmigelski merged commit 1544384 into strands-agents:main Oct 24, 2025
13 checks passed
dbschmigelski added a commit to schnetler/sdk-python that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants