fix(telemetry): removed double serialization for events

poshinchen · poshinchen · commit c89206e15af9 · 2025-10-03T13:35:58.000-04:00
diff --git a/src/strands/telemetry/tracer.py b/src/strands/telemetry/tracer.py
@@ -10,6 +10,7 @@
 from datetime import date, datetime, timezone
 from typing import Any, Dict, Mapping, Optional
 
+
 import opentelemetry.trace as trace_api
 from opentelemetry.instrumentation.threading import ThreadingInstrumentor
 from opentelemetry.trace import Span, StatusCode
@@ -307,7 +308,7 @@ def end_model_invoke_span(
                         [
                             {
                                 "role": message["role"],
-                                "parts": [{"type": "text", "content": serialize(message["content"])}],
+                                "parts": [{"type": "text", "content": message["content"]}],
                                 "finish_reason": str(stop_reason),
                             }
                         ]
@@ -362,7 +363,7 @@ def start_tool_call_span(self, tool: ToolUse, parent_span: Optional[Span] = None
                                         "type": "tool_call",
                                         "name": tool["name"],
                                         "id": tool["toolUseId"],
-                                        "arguments": [{"content": serialize(tool["input"])}],
+                                        "arguments": [{"content": tool["input"]}],
                                     }
                                 ],
                             }
@@ -417,7 +418,7 @@ def end_tool_call_span(
                                         {
                                             "type": "tool_call_response",
                                             "id": tool_result.get("toolUseId", ""),
-                                            "result": serialize(tool_result.get("content")),
+                                            "result": tool_result.get("content"),
                                         }
                                     ],
                                 }
@@ -504,7 +505,7 @@ def end_event_loop_cycle_span(
                             [
                                 {
                                     "role": tool_result_message["role"],
-                                    "parts": [{"type": "text", "content": serialize(tool_result_message["content"])}],
+                                    "parts": [{"type": "text", "content": tool_result_message["content"]}],
                                 }
                             ]
                         )
@@ -640,11 +641,7 @@ def start_multiagent_span(
             self._add_event(
                 span,
                 "gen_ai.client.inference.operation.details",
-                {
-                    "gen_ai.input.messages": serialize(
-                        [{"role": "user", "parts": [{"type": "text", "content": content}]}]
-                    )
-                },
+                {"gen_ai.input.messages": serialize([{"role": "user", "parts": [{"type": "text", "content": task}]}])},
             )
         else:
             self._add_event(
@@ -722,7 +719,7 @@ def _add_event_messages(self, span: Span, messages: Messages) -> None:
             input_messages: list = []
             for message in messages:
                 input_messages.append(
-                    {"role": message["role"], "parts": [{"type": "text", "content": serialize(message["content"])}]}
+                    {"role": message["role"], "parts": [{"type": "text", "content": message["content"]}]}
                 )
             self._add_event(
                 span, "gen_ai.client.inference.operation.details", {"gen_ai.input.messages": serialize(input_messages)}
diff --git a/tests/strands/telemetry/test_tracer.py b/tests/strands/telemetry/test_tracer.py
@@ -191,7 +191,7 @@ def test_start_model_invoke_span_latest_conventions(mock_tracer):
                     [
                         {
                             "role": messages[0]["role"],
-                            "parts": [{"type": "text", "content": serialize(messages[0]["content"])}],
+                            "parts": [{"type": "text", "content": messages[0]["content"]}],
                         }
                     ]
                 )
@@ -249,7 +249,7 @@ def test_end_model_invoke_span_latest_conventions(mock_span):
                     [
                         {
                             "role": "assistant",
-                            "parts": [{"type": "text", "content": serialize(message["content"])}],
+                            "parts": [{"type": "text", "content": message["content"]}],
                             "finish_reason": "end_turn",
                         }
                     ]
@@ -318,7 +318,7 @@ def test_start_tool_call_span_latest_conventions(mock_tracer):
                                     "type": "tool_call",
                                     "name": tool["name"],
                                     "id": tool["toolUseId"],
-                                    "arguments": [{"content": serialize(tool["input"])}],
+                                    "arguments": [{"content": tool["input"]}],
                                 }
                             ],
                         }
@@ -398,7 +398,7 @@ def test_start_swarm_span_with_contentblock_task_latest_conventions(mock_tracer)
             "gen_ai.client.inference.operation.details",
             attributes={
                 "gen_ai.input.messages": serialize(
-                    [{"role": "user", "parts": [{"type": "text", "content": '[{"text": "Original Task: foo bar"}]'}]}]
+                    [{"role": "user", "parts": [{"type": "text", "content": [{"text": "Original Task: foo bar"}]}]}]
                 )
             },
         )
@@ -502,7 +502,7 @@ def test_end_tool_call_span_latest_conventions(mock_span):
                             {
                                 "type": "tool_call_response",
                                 "id": tool_result.get("toolUseId", ""),
-                                "result": serialize(tool_result.get("content")),
+                                "result": tool_result.get("content"),
                             }
                         ],
                     }
@@ -559,7 +559,7 @@ def test_start_event_loop_cycle_span_latest_conventions(mock_tracer):
             "gen_ai.client.inference.operation.details",
             attributes={
                 "gen_ai.input.messages": serialize(
-                    [{"role": "user", "parts": [{"type": "text", "content": serialize(messages[0]["content"])}]}]
+                    [{"role": "user", "parts": [{"type": "text", "content": messages[0]["content"]}]}]
                 )
             },
         )
@@ -601,7 +601,7 @@ def test_end_event_loop_cycle_span_latest_conventions(mock_span):
                 [
                     {
                         "role": "assistant",
-                        "parts": [{"type": "text", "content": serialize(tool_result_message["content"])}],
+                        "parts": [{"type": "text", "content": tool_result_message["content"]}],
                     }
                 ]
             )
@@ -676,7 +676,7 @@ def test_start_agent_span_latest_conventions(mock_tracer):
             "gen_ai.client.inference.operation.details",
             attributes={
                 "gen_ai.input.messages": serialize(
-                    [{"role": "user", "parts": [{"type": "text", "content": '[{"text": "test prompt"}]'}]}]
+                    [{"role": "user", "parts": [{"type": "text", "content": [{"text": "test prompt"}]}]}]
                 )
             },
         )

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`from datetime import date, datetime, timezone`
`11`	`11`	`from typing import Any, Dict, Mapping, Optional`
`12`	`12`
	`13`	`+`
`13`	`14`	`import opentelemetry.trace as trace_api`
`14`	`15`	`from opentelemetry.instrumentation.threading import ThreadingInstrumentor`
`15`	`16`	`from opentelemetry.trace import Span, StatusCode`
`@@ -307,7 +308,7 @@ def end_model_invoke_span(`
`307`	`308`	`[`
`308`	`309`	`{`
`309`	`310`	`"role": message["role"],`
`310`		`- "parts": [{"type": "text", "content": serialize(message["content"])}],`
	`311`	`+ "parts": [{"type": "text", "content": message["content"]}],`
`311`	`312`	`"finish_reason": str(stop_reason),`
`312`	`313`	`}`
`313`	`314`	`]`
`@@ -362,7 +363,7 @@ def start_tool_call_span(self, tool: ToolUse, parent_span: Optional[Span] = None`
`362`	`363`	`"type": "tool_call",`
`363`	`364`	`"name": tool["name"],`
`364`	`365`	`"id": tool["toolUseId"],`
`365`		`- "arguments": [{"content": serialize(tool["input"])}],`
	`366`	`+ "arguments": [{"content": tool["input"]}],`
`366`	`367`	`}`
`367`	`368`	`],`
`368`	`369`	`}`
`@@ -417,7 +418,7 @@ def end_tool_call_span(`
`417`	`418`	`{`
`418`	`419`	`"type": "tool_call_response",`
`419`	`420`	`"id": tool_result.get("toolUseId", ""),`
`420`		`- "result": serialize(tool_result.get("content")),`
	`421`	`+ "result": tool_result.get("content"),`
`421`	`422`	`}`
`422`	`423`	`],`
`423`	`424`	`}`
`@@ -504,7 +505,7 @@ def end_event_loop_cycle_span(`
`504`	`505`	`[`
`505`	`506`	`{`
`506`	`507`	`"role": tool_result_message["role"],`
`507`		`- "parts": [{"type": "text", "content": serialize(tool_result_message["content"])}],`
	`508`	`+ "parts": [{"type": "text", "content": tool_result_message["content"]}],`
`508`	`509`	`}`
`509`	`510`	`]`
`510`	`511`	`)`
`@@ -640,11 +641,7 @@ def start_multiagent_span(`
`640`	`641`	`self._add_event(`
`641`	`642`	`span,`
`642`	`643`	`"gen_ai.client.inference.operation.details",`
`643`		`- {`
`644`		`- "gen_ai.input.messages": serialize(`
`645`		`- [{"role": "user", "parts": [{"type": "text", "content": content}]}]`
`646`		`- )`
`647`		`- },`
	`644`	`+ {"gen_ai.input.messages": serialize([{"role": "user", "parts": [{"type": "text", "content": task}]}])},`
`648`	`645`	`)`
`649`	`646`	`else:`
`650`	`647`	`self._add_event(`
`@@ -722,7 +719,7 @@ def _add_event_messages(self, span: Span, messages: Messages) -> None:`
`722`	`719`	`input_messages: list = []`
`723`	`720`	`for message in messages:`
`724`	`721`	`input_messages.append(`
`725`		`- {"role": message["role"], "parts": [{"type": "text", "content": serialize(message["content"])}]}`
	`722`	`+ {"role": message["role"], "parts": [{"type": "text", "content": message["content"]}]}`
`726`	`723`	`)`
`727`	`724`	`self._add_event(`
`728`	`725`	`span, "gen_ai.client.inference.operation.details", {"gen_ai.input.messages": serialize(input_messages)}`
Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ def test_start_model_invoke_span_latest_conventions(mock_tracer):`
`191`	`191`	`[`
`192`	`192`	`{`
`193`	`193`	`"role": messages[0]["role"],`
`194`		`- "parts": [{"type": "text", "content": serialize(messages[0]["content"])}],`
	`194`	`+ "parts": [{"type": "text", "content": messages[0]["content"]}],`
`195`	`195`	`}`
`196`	`196`	`]`
`197`	`197`	`)`
`@@ -249,7 +249,7 @@ def test_end_model_invoke_span_latest_conventions(mock_span):`
`249`	`249`	`[`
`250`	`250`	`{`
`251`	`251`	`"role": "assistant",`
`252`		`- "parts": [{"type": "text", "content": serialize(message["content"])}],`
	`252`	`+ "parts": [{"type": "text", "content": message["content"]}],`
`253`	`253`	`"finish_reason": "end_turn",`
`254`	`254`	`}`
`255`	`255`	`]`
`@@ -318,7 +318,7 @@ def test_start_tool_call_span_latest_conventions(mock_tracer):`
`318`	`318`	`"type": "tool_call",`
`319`	`319`	`"name": tool["name"],`
`320`	`320`	`"id": tool["toolUseId"],`
`321`		`- "arguments": [{"content": serialize(tool["input"])}],`
	`321`	`+ "arguments": [{"content": tool["input"]}],`
`322`	`322`	`}`
`323`	`323`	`],`
`324`	`324`	`}`
`@@ -398,7 +398,7 @@ def test_start_swarm_span_with_contentblock_task_latest_conventions(mock_tracer)`
`398`	`398`	`"gen_ai.client.inference.operation.details",`
`399`	`399`	`attributes={`
`400`	`400`	`"gen_ai.input.messages": serialize(`
`401`		`- [{"role": "user", "parts": [{"type": "text", "content": '[{"text": "Original Task: foo bar"}]'}]}]`
	`401`	`+ [{"role": "user", "parts": [{"type": "text", "content": [{"text": "Original Task: foo bar"}]}]}]`
`402`	`402`	`)`
`403`	`403`	`},`
`404`	`404`	`)`
`@@ -502,7 +502,7 @@ def test_end_tool_call_span_latest_conventions(mock_span):`
`502`	`502`	`{`
`503`	`503`	`"type": "tool_call_response",`
`504`	`504`	`"id": tool_result.get("toolUseId", ""),`
`505`		`- "result": serialize(tool_result.get("content")),`
	`505`	`+ "result": tool_result.get("content"),`
`506`	`506`	`}`
`507`	`507`	`],`
`508`	`508`	`}`
`@@ -559,7 +559,7 @@ def test_start_event_loop_cycle_span_latest_conventions(mock_tracer):`
`559`	`559`	`"gen_ai.client.inference.operation.details",`
`560`	`560`	`attributes={`
`561`	`561`	`"gen_ai.input.messages": serialize(`
`562`		`- [{"role": "user", "parts": [{"type": "text", "content": serialize(messages[0]["content"])}]}]`
	`562`	`+ [{"role": "user", "parts": [{"type": "text", "content": messages[0]["content"]}]}]`
`563`	`563`	`)`
`564`	`564`	`},`
`565`	`565`	`)`
`@@ -601,7 +601,7 @@ def test_end_event_loop_cycle_span_latest_conventions(mock_span):`
`601`	`601`	`[`
`602`	`602`	`{`
`603`	`603`	`"role": "assistant",`
`604`		`- "parts": [{"type": "text", "content": serialize(tool_result_message["content"])}],`
	`604`	`+ "parts": [{"type": "text", "content": tool_result_message["content"]}],`
`605`	`605`	`}`
`606`	`606`	`]`
`607`	`607`	`)`
`@@ -676,7 +676,7 @@ def test_start_agent_span_latest_conventions(mock_tracer):`
`676`	`676`	`"gen_ai.client.inference.operation.details",`
`677`	`677`	`attributes={`
`678`	`678`	`"gen_ai.input.messages": serialize(`
`679`		`- [{"role": "user", "parts": [{"type": "text", "content": '[{"text": "test prompt"}]'}]}]`
	`679`	`+ [{"role": "user", "parts": [{"type": "text", "content": [{"text": "test prompt"}]}]}]`
`680`	`680`	`)`
`681`	`681`	`},`
`682`	`682`	`)`