From ddc83656552baecbd222ecde2cc7c66cb991f8df Mon Sep 17 00:00:00 2001 From: "Zachary J. Fields" Date: Fri, 26 Sep 2025 13:38:29 -0500 Subject: [PATCH 1/3] Define default pins for Cygnet/Swan Serial2 Add default pins for Serial2 instance. Signed-off-by: Zachary J. Fields --- .../L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h | 8 ++++++++ .../variant_SWAN_R5.h | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h b/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h index bc4ff379dd..9e466ebba9 100644 --- a/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h +++ b/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h @@ -153,6 +153,14 @@ #define PIN_SERIAL_TX PA9 #endif +// Default pin used for generic `Serial2` instance +#ifndef PIN_SERIAL2_RX + #define PIN_SERIAL2_RX PA3 +#endif +#ifndef PIN_SERIAL2_TX + #define PIN_SERIAL2_TX PA2 +#endif + // LPUART1 #ifndef PIN_SERIAL_LP1_RX #define PIN_SERIAL_LP1_RX PB10 diff --git a/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h b/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h index c4c5b2de0b..ea1f1ac18b 100644 --- a/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h +++ b/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h @@ -236,6 +236,14 @@ #define PIN_SERIAL_TX PA9 #endif +// Default pin used for generic 'Serial2' instance +#ifndef PIN_SERIAL2_RX + #define PIN_SERIAL2_RX PC5 +#endif +#ifndef PIN_SERIAL2_TX + #define PIN_SERIAL2_TX PC4 +#endif + // LPUART1 #ifndef PIN_SERIAL_LP1_RX #define PIN_SERIAL_LP1_RX PG8 From 2413da0b7643bc2fad49d986576aeb13e2f879a6 Mon Sep 17 00:00:00 2001 From: "Zachary J. Fields" Date: Fri, 3 Oct 2025 09:46:03 -0500 Subject: [PATCH 2/3] Apply suggestions from code review Signed-off-by: Zachary J. Fields --- .../STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h b/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h index 9e466ebba9..2b64142628 100644 --- a/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h +++ b/variants/STM32L4xx/L433C(B-C)(T-U)_L443CC(T-U)/variant_CYGNET.h @@ -155,10 +155,10 @@ // Default pin used for generic `Serial2` instance #ifndef PIN_SERIAL2_RX - #define PIN_SERIAL2_RX PA3 + #define PIN_SERIAL2_RX PA3_ALT1 #endif #ifndef PIN_SERIAL2_TX - #define PIN_SERIAL2_TX PA2 + #define PIN_SERIAL2_TX PA2_ALT1 #endif // LPUART1 From fcf62426120fef791c5490f1f1a6e0fe1e5eccb8 Mon Sep 17 00:00:00 2001 From: "Zachary J. Fields" Date: Mon, 6 Oct 2025 15:28:35 -0500 Subject: [PATCH 3/3] Update variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h Co-authored-by: Frederic Pillon Signed-off-by: Zachary J. Fields --- .../variant_SWAN_R5.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h b/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h index ea1f1ac18b..01f0144f33 100644 --- a/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h +++ b/variants/STM32L4xx/L4R5Z(G-I)Y_L4R9Z(G-I)Y_L4S5ZIY_L4S9ZIY/variant_SWAN_R5.h @@ -236,12 +236,12 @@ #define PIN_SERIAL_TX PA9 #endif -// Default pin used for generic 'Serial2' instance -#ifndef PIN_SERIAL2_RX - #define PIN_SERIAL2_RX PC5 +// Default pin used for generic 'Serial3' instance +#ifndef PIN_SERIAL3_RX + #define PIN_SERIAL3_RX PC5 #endif -#ifndef PIN_SERIAL2_TX - #define PIN_SERIAL2_TX PC4 +#ifndef PIN_SERIAL3_TX + #define PIN_SERIAL3_TX PC4 #endif // LPUART1