Adding new variant for Generic G070xxT #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
suggested changes
Feb 3, 2022
Contributor
ABOSTM
left a comment
ABOSTM
left a comment
There was a problem hiding this comment.
Hi @e-tinkers
Thanks for this PR, there was already a PR #1609 but I prefer to keep yours as it supersedes #1609
One minor comment otherwise Looks Good To Me.
By the way you could squash the whole in a single commit.
Generally we don't create commits for a fix (like Astyle), but directly amend the faulty commit.
Thanks
ABOSTM
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
I run the AStyle check and Action locally before commit, all passed.