Skip to content

Conversation

@danatcofo
Copy link
Contributor

No description provided.

@danatcofo danatcofo self-assigned this Feb 7, 2017
@sporty81
Copy link
Contributor

sporty81 commented Feb 7, 2017

I thought we handled this because the log msgid was a sequentialguid and you could sort by it?

@danatcofo
Copy link
Contributor Author

danatcofo commented Feb 7, 2017

@sporty81 this is for ES performance. Sorting on the id performs terribly. sorting on an integer like this performs awesomely. We have platform code in queue (PR Pending) to convert the uid order into an integer like this does here within a single batch. However doing it here ensures that the order would be good even across multiple batches.

@sporty81
Copy link
Contributor

sporty81 commented Feb 7, 2017

Can we do the sort on the guid in our API (one time) and add the order field there so we don't have to mess with all of our libraries?

@danatcofo
Copy link
Contributor Author

danatcofo commented Feb 7, 2017

We are doing it in the workers, however we wanted to provided an option for clients on the lib side should they notice any inconsistencies (however unlikely). This update would be entirely optional and not required to support our performance tunings.

@sporty81 sporty81 merged commit 42b08d9 into master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants