Skip to content

Conversation

@danatcofo
Copy link
Contributor

This contains the fix for #129 to allow for not capturing the username from web error captures.

Also contains an update to allow local devs to build the project without the Netreo.snk available.

Copy link
Contributor

@rakista112 rakista112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssembleyKeyFile isn't documented but AssemblyKeyFileAttribute is.
I'd recommend using sn -vf {.nupkg filename} as a test.
Also, this doesn't seem to generate a strong name signed package

C:\Users\rakis\Downloads>sn -vf StackifyLib.signed.2.2.9-beta.nupkg

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

StackifyLib.signed.2.2.9-beta.nupkg does not represent a strongly named assembly

Ray

@danatcofo
Copy link
Contributor Author

danatcofo commented May 27, 2022

@rakista112 AssemblyKeyFile IS AssemblyKeyFileAttribute. Its the same thing, same code, same class. Attribute is assumed as a standard dot net rule for all Attributes. Its a bit of dotnet sugar.

If you look at the rest of the changes to the yml, you will notice that I uncomment the AssemblyKeyFile prior to build. Basically we are running into the problem that you have to have the netreo.snk on the filesystem to build the application locally. If you don't your shit out of luck. Due to this, I updated the AssemblyInfo.cs files to comment out the AssemblyKeyFile attribute and have the yml uncomment those lines as part of the build process.

Ideally what should of been done is to have the projects be delay signed and the signing set up via the csproj's rather than the AssemblyInfo.cs files. If it had been done via the csproj files we could of wrapped the properties in a file exists test so that it only signed if the file existed.

@t-lair t-lair merged commit c9a75b4 into develop Jun 3, 2022
@t-lair t-lair deleted the gdpr-error-capture branch June 3, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants