From 99d4323b298a0bd5f4f3b75f815af234a31e3baf Mon Sep 17 00:00:00 2001 From: Justin Carpentier Date: Wed, 14 Aug 2024 13:54:13 +0200 Subject: [PATCH 1/2] windows: remove PathManager as we only support Python 3.8+ --- python/eigenpy/windows_dll_manager.py | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/python/eigenpy/windows_dll_manager.py b/python/eigenpy/windows_dll_manager.py index 8edb419f2..54e8631d8 100644 --- a/python/eigenpy/windows_dll_manager.py +++ b/python/eigenpy/windows_dll_manager.py @@ -1,6 +1,5 @@ import contextlib import os -import sys def get_dll_paths(): @@ -22,20 +21,6 @@ def get_dll_paths(): return eigenpy_paths.split(os.pathsep) -class PathManager(contextlib.AbstractContextManager): - """Restore PATH state after importing Python module""" - - def add_dll_directory(self, dll_dir: str): - os.environ["PATH"] += os.pathsep + dll_dir - - def __enter__(self): - self.old_path = os.environ["PATH"] - return self - - def __exit__(self, *exc_details): - os.environ["PATH"] = self.old_path - - class DllDirectoryManager(contextlib.AbstractContextManager): """Restore DllDirectory state after importing Python module""" @@ -59,7 +44,4 @@ def __exit__(self, *exc_details): def build_directory_manager(): - if sys.version_info >= (3, 8): - return DllDirectoryManager() - else: - return PathManager() + return DllDirectoryManager() From 1f165c57e85307370936ed1f58af367c291480f5 Mon Sep 17 00:00:00 2001 From: Justin Carpentier Date: Wed, 14 Aug 2024 13:55:51 +0200 Subject: [PATCH 2/2] changelog: sync --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 686116d34..3b81eef04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ### Added - Add compatibility with jrl-cmakemodules workspace ([#485](https://github.com/stack-of-tasks/eigenpy/pull/485)) +- Remove support of Python 3.7 ([#490](https://github.com/stack-of-tasks/eigenpy/pull/490)) ### Fixed - Remove CMake CMP0167 warnings ([#487](https://github.com/stack-of-tasks/eigenpy/pull/487))