Skip to content

Conversation

@jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Apr 30, 2024

Related Issue(s):

Description:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@jonhealy1 jonhealy1 marked this pull request as ready for review May 1, 2024 03:49
@jonhealy1 jonhealy1 marked this pull request as draft May 1, 2024 03:50
@jonhealy1 jonhealy1 marked this pull request as ready for review May 1, 2024 10:34
@jonhealy1 jonhealy1 requested a review from vincentsarago May 2, 2024 11:10
@jonhealy1
Copy link
Collaborator Author

The queryables tests are broken

) -> Optional[Union[stac_types.Collection, Response]]:
"""Update collection."""

col = collection.model_dump(mode="json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by definition we should get a pydantic object as input but for some reason we get a Dict 😬

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yea weird lol

@vincentsarago vincentsarago merged commit 5731518 into feature/update-stac-fastapi-3.0 May 3, 2024
@vincentsarago vincentsarago deleted the update-tests branch May 3, 2024 18:47
vincentsarago added a commit that referenced this pull request May 7, 2024
* update stac-fastapi to next major version

* update transaction endpoint

* fix 201 errors

* 201 in conftest

* use latest stac-fastapi commit

* Update tests (#111)

* update test item tests

* test collection tests

* lint

* test postgres

* test api

* more

* update item

* revert

* remove hack

* Update stac_fastapi/pgstac/core.py

Co-authored-by: Vincent Sarago <[email protected]>

* fix types

---------

Co-authored-by: Vincent Sarago <[email protected]>

* update and remove deprecated

* update deprecated methods

* remove context extension

* update changelog

---------

Co-authored-by: jonhealy1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants