Blocking bulk_items endpoint when ENABLE_DATETIME_INDEX_FILTERING #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…INDEX_FILTERING set true
Collaborator
|
@z-mrozu we should probably create an issue to eventually fix this - if it can be fixed |
Contributor
Author
|
@jonhealy1 I'm not sure if we'd want to - datetime index filtering by @GrzegorzPustulka was implemented only in |
Collaborator
|
I was thinking more along the lines of having an async bulk transactions client. Your recommendation to post a feature collection to the /items endpoint is really good. |
jonhealy1
approved these changes
Sep 13, 2025
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 15, 2025
…ac-utils#438) **Description:** The `/collections/{collection_id}/bulk_items` endpoint does not work when `ENABLE_DATETIME_INDEX_FILTERING` is set to true, as only the async `/collections/{collection_id}/items` version was implemented while the sync `/collections/{collection_id}/bulk_items` wasn't. This PR blocks the /bulk_items endpoint when `ENABLE_DATETIME_INDEX_FILTERING` is set to true. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 15, 2025
…ac-utils#438) **Description:** The `/collections/{collection_id}/bulk_items` endpoint does not work when `ENABLE_DATETIME_INDEX_FILTERING` is set to true, as only the async `/collections/{collection_id}/items` version was implemented while the sync `/collections/{collection_id}/bulk_items` wasn't. This PR blocks the /bulk_items endpoint when `ENABLE_DATETIME_INDEX_FILTERING` is set to true. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 16, 2025
…ac-utils#438) **Description:** The `/collections/{collection_id}/bulk_items` endpoint does not work when `ENABLE_DATETIME_INDEX_FILTERING` is set to true, as only the async `/collections/{collection_id}/items` version was implemented while the sync `/collections/{collection_id}/bulk_items` wasn't. This PR blocks the /bulk_items endpoint when `ENABLE_DATETIME_INDEX_FILTERING` is set to true. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 23, 2025
…ac-utils#438) **Description:** The `/collections/{collection_id}/bulk_items` endpoint does not work when `ENABLE_DATETIME_INDEX_FILTERING` is set to true, as only the async `/collections/{collection_id}/items` version was implemented while the sync `/collections/{collection_id}/bulk_items` wasn't. This PR blocks the /bulk_items endpoint when `ENABLE_DATETIME_INDEX_FILTERING` is set to true. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 23, 2025
…ac-utils#438) **Description:** The `/collections/{collection_id}/bulk_items` endpoint does not work when `ENABLE_DATETIME_INDEX_FILTERING` is set to true, as only the async `/collections/{collection_id}/items` version was implemented while the sync `/collections/{collection_id}/bulk_items` wasn't. This PR blocks the /bulk_items endpoint when `ENABLE_DATETIME_INDEX_FILTERING` is set to true. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
/collections/{collection_id}/bulk_itemsendpoint does not work whenENABLE_DATETIME_INDEX_FILTERINGis set to true, as only the async/collections/{collection_id}/itemsversion was implemented while the sync/collections/{collection_id}/bulk_itemswasn't. This PR blocks the /bulk_items endpoint whenENABLE_DATETIME_INDEX_FILTERINGis set to true.PR Checklist:
pre-commit run --all-files)make test)