fix: apply recommendations

Author: Yuri Zmytrakov

stac_fastapi/core/stac_fastapi/core/core.py

@@ -19,6 +19,7 @@
 from stac_pydantic.links import Relations
 from stac_pydantic.shared import BBox, MimeTypes
 from stac_pydantic.version import STAC_VERSION
+from stac_fastapi.core.utilities import get_bool_env
 
 from stac_fastapi.core.base_database_logic import BaseDatabaseLogic
 from stac_fastapi.core.base_settings import ApiBaseSettings
@@ -277,11 +278,13 @@ async def all_collections(
                 sort = parsed_sort
 
         current_url = str(request.url)
-        redis = None
-        try:
-            redis = await connect_redis_sentinel()
-        except Exception:
-            redis = None
+        redis_enable = get_bool_env("REDIS_ENABLE", default=False)
+
+        if redis_enable:
+            try:
+                redis = await connect_redis_sentinel()
+            except Exception:
+                redis = None
 
         # Convert q to a list if it's a string
         q_list = None
@@ -311,7 +314,7 @@ async def all_collections(
             },
         ]
 
-        if redis:
+        if redis_enable and redis:
             if next_token:
                 await save_self_link(redis, next_token, current_url)
 
@@ -557,10 +560,14 @@ async def post_search(
             HTTPException: If there is an error with the cql2_json filter.
         """
         base_url = str(request.base_url)
-        try:
-            redis = await connect_redis_sentinel()
-        except Exception:
-            redis = None
+        redis_enable = get_bool_env("REDIS_ENABLE", default=False)
+
+        redis = None
+        if redis_enable:
+            try:
+                redis = await connect_redis_sentinel()
+            except Exception:
+                redis = None
 
         search = self.database.make_search()
 
@@ -690,7 +697,7 @@ async def post_search(
                 )
         links.extend(collection_links)
 
-        if redis:
+        if redis_enable and redis:
             self_link = str(request.url)
             await save_self_link(redis, next_token, self_link)