Add a test

Author: Rob-Hague

test/Renci.SshNet.IntegrationTests/AuthenticationMethodFactory.cs

@@ -69,7 +69,7 @@ public PrivateKeyAuthenticationMethod CreateRegularUserPrivateKeyAuthenticationM
             return new PrivateKeyAuthenticationMethod(Users.Regular.UserName, new PrivateKeyFile(memoryStream));
         }
 
-        public PasswordAuthenticationMethod CreateRegulatUserPasswordAuthenticationMethod()
+        public PasswordAuthenticationMethod CreateRegularUserPasswordAuthenticationMethod()
         {
             return new PasswordAuthenticationMethod(Users.Regular.UserName, Users.Regular.Password);
         }

test/Renci.SshNet.IntegrationTests/AuthenticationTests.cs

@@ -161,7 +161,7 @@ public void Multifactor_Password_ExceedsPartialSuccessLimit()
                              .Update()
                              .Restart();
 
-            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod());
+            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod());
             using (var client = new SftpClient(connectionInfo))
             {
                 try
@@ -187,7 +187,7 @@ public void Multifactor_Password_MatchPartialSuccessLimit()
                              .Update()
                              .Restart();
 
-            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod());
+            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod());
             using (var client = new SftpClient(connectionInfo))
             {
                 client.Connect();
@@ -205,7 +205,7 @@ public void Multifactor_Password_Or_PublicKeyAndKeyboardInteractive()
                              .Restart();
 
             var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPrivateKeyAuthenticationMethod(),
-                                                               _authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod());
+                                                               _authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod());
             using (var client = new SftpClient(connectionInfo))
             {
                 client.Connect();
@@ -243,7 +243,7 @@ public void Multifactor_PasswordAndPublicKey_Or_PasswordAndPassword()
                              .Update()
                              .Restart();
 
-            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod(),
+            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod(),
                                                                _authenticationMethodFactory.CreateRegularUserPrivateKeyAuthenticationMethodWithBadKey());
             using (var client = new SftpClient(connectionInfo))
             {
@@ -275,14 +275,14 @@ public void Multifactor_PasswordAndPassword_Or_PublicKey()
                              .Update()
                              .Restart();
 
-            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod(),
+            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod(),
                                                                _authenticationMethodFactory.CreateRegularUserPrivateKeyAuthenticationMethodWithBadKey());
             using (var client = new SftpClient(connectionInfo))
             {
                 client.Connect();
             }
 
-            connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod());
+            connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod());
             using (var client = new SftpClient(connectionInfo))
             {
                 client.Connect();
@@ -297,13 +297,13 @@ public void Multifactor_Password_Or_Password()
                              .Update()
                              .Restart();
 
-            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod());
+            var connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod());
             using (var client = new SftpClient(connectionInfo))
             {
                 client.Connect();
             }
 
-            connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegulatUserPasswordAuthenticationMethod(),
+            connectionInfo = _connectionInfoFactory.Create(_authenticationMethodFactory.CreateRegularUserPasswordAuthenticationMethod(),
                                                            _authenticationMethodFactory.CreateRegularUserPrivateKeyAuthenticationMethodWithBadKey());
             using (var client = new SftpClient(connectionInfo))
             {
@@ -423,5 +423,35 @@ public void KeyboardInteractiveConnectionInfo()
             Assert.AreEqual(connectionInfo.Host, SshServerHostName);
             Assert.AreEqual(connectionInfo.Username, User.UserName);
         }
+
+        [TestMethod]
+        public void KeyboardInteractive_NoReponseSet_ThrowsSshAuthenticationException()
+        {
+            // ...instead of a cryptic ArgumentNullException
+            // https://github.com/sshnet/SSH.NET/issues/382
+
+            _remoteSshdConfig.WithAuthenticationMethods(Users.Regular.UserName, "keyboard-interactive")
+                             .WithChallengeResponseAuthentication(true)
+                             .WithKeyboardInteractiveAuthentication(true)
+                             .WithUsePAM(true)
+                             .Update()
+                             .Restart();
+
+            var connectionInfo = _connectionInfoFactory.Create(new KeyboardInteractiveAuthenticationMethod(Users.Regular.UserName));
+
+            using (var client = new SftpClient(connectionInfo))
+            {
+                try
+                {
+                    client.Connect();
+                    Assert.Fail();
+                }
+                catch (SshAuthenticationException ex)
+                {
+                    Assert.IsNull(ex.InnerException);
+                    Assert.IsTrue(ex.Message.StartsWith("AuthenticationPrompt.Response is null for prompt \"Password: \""), $"Message was \"{ex.Message}\"");
+                }
+            }
+        }
     }
 }