Skip to content

Conversation

@rjrjr
Copy link
Collaborator

@rjrjr rjrjr commented Jun 29, 2020

Undoing a crime against nature and common sense.

Closes #9

@rjrjr rjrjr requested a review from a team as a code owner June 29, 2020 00:27
@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

Oops, I was behind main. Updating…

@rjrjr rjrjr force-pushed the rjrjr/nextState-was-a-terrible-idea branch from 61aa679 to aa1aa55 Compare June 29, 2020 01:19
@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

@zach-klippenstein Any idea what that dokka failure means?

@zach-klippenstein
Copy link
Collaborator

e: /home/runner/work/workflow-kotlin/workflow-kotlin/workflow-runtime/src/test/java/com/squareup/workflow/RenderWorkflowInTest.kt: (377, 15): Unresolved reference: nextState

It looks like a compilation error, but I'm not sure why the assemble task didn't fail. Does it build locally?

@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

gw clean build connectedCheck

Is there more to run these days?

@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

Did find a lot of stale nextState in deprecation messages. Fixing…

@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

But there is no nextState in the class it's complaining about. :/ And that test compiles and passes.

@rjrjr rjrjr force-pushed the rjrjr/nextState-was-a-terrible-idea branch from aa1aa55 to c32df8b Compare June 29, 2020 03:09
@zach-klippenstein
Copy link
Collaborator

Yea, everything builds fine for me locally too, including dokka. Let's see if the rebuild passes I guess.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

Found it, in workflow-runtime. Don't understand how top level build missed that.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Jun 29, 2020

Or a rebase weirdness? I don't know, tired, it works now.

Undoing a crime against nature and common sense.

Closes #9
@rjrjr rjrjr force-pushed the rjrjr/nextState-was-a-terrible-idea branch from c32df8b to f68cf43 Compare June 29, 2020 03:25
@zach-klippenstein
Copy link
Collaborator

I must be tired too, still confused.

@rjrjr rjrjr merged commit c19ba34 into main Jun 29, 2020
@rjrjr rjrjr deleted the rjrjr/nextState-was-a-terrible-idea branch June 29, 2020 04:00
@forrestbice
Copy link
Member

@rjrjr thanks for making this change! 🙌 Excited for this to make it to PoS

@Blisse
Copy link
Contributor

Blisse commented Jun 29, 2020

Perhaps silly, but would've been happy to also see immutable val called currentState in addition to nextState.

zach-klippenstein added a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Kotlin action nextState to state!

5 participants