Skip to content

Conversation

@zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jun 28, 2020

  • WorkflowTester -> WorkflowTestRuntime
  • Workflow.test() -> Workflow.launchForTestingWith()
  • Workflow.testFromState() -> Workflow.launchForTestingFromStateWith()
  • Workflow.testFromStart() -> Workflow.launchForTestingFromStartWith()
  • Workflow.renderTester() -> Workflow.testRender()

All old names are kept around as deprecated typealiases or inline function
aliases with replacements.

Fixes #58.

@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 28, 2020
@zach-klippenstein zach-klippenstein requested a review from a team as a code owner June 28, 2020 21:07
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/improve-testing-api-names branch 3 times, most recently from 95c43b6 to 4292a0f Compare June 29, 2020 02:36
@zach-klippenstein
Copy link
Collaborator Author

@rjrjr Updated testRender() name as you suggested, what's your LOGF on the WorkflowTester stuff?

- `WorkflowTester` -> `WorkflowTestRuntime`
- `Workflow.test()` -> `Workflow.launchForTestingWith()`
- `Workflow.testFromState()` -> `Workflow.launchForTestingFromStateWith()`
- `Workflow.testFromStart()` -> `Workflow.launchForTestingFromStartWith()`
- `Workflow.renderTester()` -> `Workflow.testRender()`

All old names are kept around as deprecated typealiases or inline function
aliases with replacements.

Fixes #58.
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/improve-testing-api-names branch from 4292a0f to 1d6cd78 Compare June 29, 2020 03:03
@rjrjr
Copy link
Collaborator

rjrjr commented Jun 29, 2020

We're clear I'm good with all this now, yes?

@zach-klippenstein zach-klippenstein merged commit a1c6edf into main Jun 29, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/improve-testing-api-names branch June 29, 2020 13:28
zach-klippenstein added a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kotlin integration testing API entry points need better names

3 participants