Skip to content

Revert "Emit output before next render pass." #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Revert "Emit output before next render pass." #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions workflow-runtime/src/main/java/com/squareup/workflow1/RenderWorkflow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,12 @@ fun <PropsT, OutputT, RenderingT> renderWorkflowIn(
// It might look weird to start by consuming the output before getting the rendering below,
// but remember the first render pass already occurred above, before this coroutine was even
// launched.
runner.nextOutput()
?.let { onOutput(it.value) }
val output = runner.nextOutput()

// After receiving an output, the next render pass must be done before emitting that output,
// so that the workflow states appear consistent to observers of the outputs and renderings.
renderingsAndSnapshots.value = runner.nextRendering()
output?.let { onOutput(it.value) }
}
}

Expand Down
4 changes: 2 additions & 2 deletions workflow-runtime/src/test/java/com/squareup/workflow1/RenderWorkflowInTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,8 @@ class RenderWorkflowInTest {
assertEquals(
listOf(
"rendering({no output})",
"output(output)",
"rendering(output)"
"rendering(output)",
"output(output)"
),
events
)
Expand Down