Skip to content

Commit b4565c2

Browse files
committed
Disables HelloWorkflowFragmentAppTest on API 21 b/c LeakCanary
Or more likely, b/c LeakCanary exposes an obscure bug in Jetpack and life is just too short. Fixes #582.
1 parent 18c2c58 commit b4565c2

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

samples/hello-workflow-fragment/src/androidTest/java/com/squareup/sample/helloworkflowfragment/HelloWorkflowFragmentAppTest.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
package com.squareup.sample.helloworkflowfragment
22

3+
import android.os.Build
34
import androidx.test.espresso.action.ViewActions.click
45
import androidx.test.espresso.assertion.ViewAssertions.matches
56
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
67
import androidx.test.espresso.matcher.ViewMatchers.withText
78
import androidx.test.ext.junit.rules.ActivityScenarioRule
89
import androidx.test.ext.junit.runners.AndroidJUnit4
10+
import androidx.test.filters.SdkSuppress
911
import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
1012
import com.squareup.workflow1.ui.internal.test.inAnyView
1113
import org.hamcrest.Matchers.containsString
1214
import org.junit.Rule
1315
import org.junit.Test
1416
import org.junit.runner.RunWith
1517

18+
// Life is too short to debug why LeakCanary breaks this on API 21
19+
// https://github.com/square/workflow-kotlin/issues/582
20+
@SdkSuppress(minSdkVersion = Build.VERSION_CODES.M)
1621
@RunWith(AndroidJUnit4::class)
1722
@OptIn(WorkflowUiExperimentalApi::class)
1823
class HelloWorkflowFragmentAppTest {
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
package com.squareup.sample.helloworkflowfragment
2+
3+
import androidx.test.ext.junit.runners.AndroidJUnit4
4+
import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
5+
import org.junit.Test
6+
import org.junit.runner.RunWith
7+
8+
/**
9+
* Stub test to avoid failing b/c no tests when suppressing [HelloWorkflowFragmentAppTest]
10+
* on API 21.
11+
*
12+
* https://github.com/square/workflow-kotlin/issues/582
13+
*/
14+
@RunWith(AndroidJUnit4::class)
15+
@OptIn(WorkflowUiExperimentalApi::class)
16+
class StubTest {
17+
@Test fun fml() {
18+
}
19+
}

0 commit comments

Comments
 (0)