WorkflowLayout.start now requires a Lifecycle parameter.

On a lot of Samsung devices running Anroid 12 / API 30, the sketchy `WorkflowLayout.takeWhileAttached` method at the heart of `WorkflowLayout.start` was having surprising effects -- we'd see redundant calls to `View.onAttachedToWindow`. The problem goes away if we get more conventional and use the new `repeatOnLifecycle` function as described in [this blog post](https://medium.com/androiddevelopers/a-safer-way-to-collect-flows-from-android-uis-23080b1f8bda).

The old methods are deprecated and will be deleted soon.

Author: rjrjr

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocomposebinding/HelloBindingActivity.kt

@@ -35,22 +35,19 @@ class HelloBindingActivity : AppCompatActivity() {
 
     val model: HelloBindingModel by viewModels()
     setContentView(
-        WorkflowLayout(this).apply {
-          start(
-              renderings = model.renderings,
-              environment = viewEnvironment
-          )
-        }
+      WorkflowLayout(this).apply {
+        start(lifecycle, model.renderings, viewEnvironment)
+      }
     )
   }
 
   class HelloBindingModel(savedState: SavedStateHandle) : ViewModel() {
     @OptIn(WorkflowUiExperimentalApi::class)
     val renderings: StateFlow<Any> by lazy {
       renderWorkflowIn(
-          workflow = HelloWorkflow,
-          scope = viewModelScope,
-          savedStateHandle = savedState
+        workflow = HelloWorkflow,
+        scope = viewModelScope,
+        savedStateHandle = savedState
       )
     }
   }

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocomposeworkflow/HelloComposeWorkflowActivity.kt

@@ -17,7 +17,7 @@ class HelloComposeWorkflowActivity : AppCompatActivity() {
     super.onCreate(savedInstanceState)
     val model: HelloComposeModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings) }
     )
   }
 

samples/compose-samples/src/main/java/com/squareup/sample/compose/inlinerendering/InlineRenderingActivity.kt

@@ -21,9 +21,7 @@ class InlineRenderingActivity : AppCompatActivity() {
 
     val model: HelloBindingModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply {
-        start(renderings = model.renderings)
-      }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings) }
     )
   }
 

samples/compose-samples/src/main/java/com/squareup/sample/compose/nestedrenderings/NestedRenderingsActivity.kt

@@ -38,10 +38,7 @@ class NestedRenderingsActivity : AppCompatActivity() {
     val model: NestedRenderingsModel by viewModels()
     setContentView(
       WorkflowLayout(this).apply {
-        start(
-          renderings = model.renderings,
-          environment = viewEnvironment
-        )
+        start(lifecycle, model.renderings, viewEnvironment)
       }
     )
   }

samples/containers/app-poetry/src/main/java/com/squareup/sample/poetryapp/PoetryActivity.kt

@@ -26,7 +26,7 @@ class PoetryActivity : AppCompatActivity() {
 
     val model: PoetryModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings, viewRegistry) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings, viewRegistry) }
     )
   }
 

samples/containers/app-raven/src/main/java/com/squareup/sample/ravenapp/RavenActivity.kt

@@ -30,7 +30,7 @@ class RavenActivity : AppCompatActivity() {
 
     val model: RavenModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings, viewRegistry) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings, viewRegistry) }
     )
 
     lifecycleScope.launch {

samples/containers/hello-back-button/src/main/java/com/squareup/sample/hellobackbutton/HelloBackButtonActivity.kt

@@ -27,7 +27,7 @@ class HelloBackButtonActivity : AppCompatActivity() {
 
     val model: HelloBackButtonModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings, viewRegistry) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings, viewRegistry) }
     )
 
     lifecycleScope.launch {

samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/DungeonActivity.kt

@@ -17,7 +17,7 @@ class DungeonActivity : AppCompatActivity() {
     val model: TimeMachineModel by viewModels { component.timeMachineModelFactory }
 
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings, component.viewRegistry) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings, component.viewRegistry) }
     )
   }
 }

samples/hello-workflow-fragment/src/main/java/com/squareup/sample/helloworkflowfragment/HelloWorkflowFragment.kt

@@ -23,10 +23,10 @@ class HelloWorkflowFragment : Fragment() {
     // This ViewModel will survive configuration changes. It's instantiated
     // by the first call to ViewModelProvider.get(), and that original instance is returned by
     // succeeding calls, until this Fragment session ends.
-    val model: HelloViewModel = ViewModelProvider(this).get(HelloViewModel::class.java)
+    val model: HelloViewModel = ViewModelProvider(this)[HelloViewModel::class.java]
 
     return WorkflowLayout(inflater.context).apply {
-      start(model.renderings)
+      start(lifecycle, model.renderings)
     }
   }
 }

samples/hello-workflow/src/main/java/com/squareup/sample/helloworkflow/HelloWorkflowActivity.kt

@@ -21,7 +21,7 @@ class HelloWorkflowActivity : AppCompatActivity() {
     // succeeding calls.
     val model: HelloViewModel by viewModels()
     setContentView(
-      WorkflowLayout(this).apply { start(model.renderings) }
+      WorkflowLayout(this).apply { start(lifecycle, model.renderings) }
     )
   }
 }