Adds (failing) DecorativeViewFactory double update test

Author: rjrjr

workflow-ui/core-android/src/androidTest/java/com/squareup/workflow1/ui/DecorativeViewFactoryTest.kt

@@ -101,6 +101,80 @@ internal class DecorativeViewFactoryTest {
     )
   }
 
+  // https://github.com/square/workflow-kotlin/issues/597
+  @Test fun double_wrapping_only_calls_showRendering_once() {
+    val events = mutableListOf<String>()
+
+    val innerViewFactory = object : ViewFactory<InnerRendering> {
+      override val type = InnerRendering::class
+      override fun buildView(
+        initialRendering: InnerRendering,
+        initialViewEnvironment: ViewEnvironment,
+        contextForNewView: Context,
+        container: ViewGroup?
+      ): View = InnerView(contextForNewView).apply {
+        bindShowRendering(initialRendering, initialViewEnvironment) { rendering, _ ->
+          events += "inner showRendering $rendering"
+        }
+      }
+    }
+
+    val envString = object : ViewEnvironmentKey<String>(String::class) {
+      override val default: String get() = "Not set"
+    }
+
+    val outerViewFactory = DecorativeViewFactory(
+      type = OuterRendering::class,
+      map = { outer, env ->
+        val enhancedEnv = env + (envString to "Outer Updated environment")
+        Pair(outer.wrapped, enhancedEnv)
+      },
+      initializeView = {
+        val outerRendering = getRendering<OuterRendering>()
+        events += "outer initializeView $outerRendering ${environment!![envString]}"
+        showFirstRendering()
+        events += "exit outer initializeView"
+      }
+    )
+
+    val wayOutViewFactory = DecorativeViewFactory(
+      type = WayOutRendering::class,
+      map = { wayOut, env ->
+        val enhancedEnv = env + (envString to "Way Out Updated environment")
+        Pair(wayOut.wrapped, enhancedEnv)
+      },
+      initializeView = {
+        val wayOutRendering = getRendering<WayOutRendering>()
+        events += "way out initializeView $wayOutRendering ${environment!![envString]}"
+        showFirstRendering()
+        events += "exit way out initializeView"
+      }
+    )
+    val viewRegistry = ViewRegistry(innerViewFactory, outerViewFactory, wayOutViewFactory)
+    val viewEnvironment = ViewEnvironment(mapOf(ViewRegistry to viewRegistry))
+
+    viewRegistry.buildView(
+      WayOutRendering("way out", OuterRendering("outer", InnerRendering("inner"))),
+      viewEnvironment,
+      instrumentation.context
+    )
+
+    assertThat(events).containsExactly(
+      "way out initializeView " +
+        "WayOutRendering(wayOutData=way out, wrapped=" +
+        "OuterRendering(outerData=outer, wrapped=" +
+        "InnerRendering(innerData=inner))) " +
+        "Way Out Updated environment",
+      "outer initializeView " +
+        "OuterRendering(outerData=outer, wrapped=" +
+        "InnerRendering(innerData=inner)) " +
+        "Outer Updated environment",
+      "inner showRendering InnerRendering(innerData=inner)",
+      "exit outer initializeView",
+      "exit way out initializeView"
+    )
+  }
+
   @Test fun subsequent_showRendering_calls_wrapped_showRendering() {
     val events = mutableListOf<String>()
 
@@ -148,6 +222,10 @@ internal class DecorativeViewFactoryTest {
     val outerData: String,
     val wrapped: InnerRendering
   )
+  private data class WayOutRendering(
+    val wayOutData: String,
+    val wrapped: OuterRendering
+  )
 
   private class InnerView(context: Context) : View(context)
 }