Skip to content

Commit c37e034

Browse files
committed
Merge branch 'develop' of https://github.com/sql-machine-learning/sqlflow into move_xgboost_objective_to_attr
2 parents 0e16b2d + afda622 commit c37e034

13 files changed

+5
-1978
lines changed

doc/ant-xgboost_design.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# _Design:_ ant-xgboost on sqlflow
22

3+
**NOTE: ant-xgboost on SQLFlow has moved to [backup_antxgboot_work branch](https://github.com/sql-machine-learning/sqlflow/tree/backup_antxgboost_work)**
4+
35
## Overview
46

57
This is a design doc about why and how to support running ant-xgboost via sqlflow as a machine learning estimator.

doc/ant-xgboost_user_guide.md

Lines changed: 0 additions & 221 deletions
This file was deleted.

sql/codegen_analyze.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func genAnalyzer(pr *extendedSelect, db *DB, cwd, modelDir string) (*bytes.Buffe
8585
if err != nil {
8686
return nil, fmt.Errorf("loadModelMeta %v", err)
8787
}
88-
if !strings.HasPrefix(strings.ToUpper(pr.estimator), `XGB.`) {
88+
if !strings.HasPrefix(strings.ToUpper(pr.estimator), `XGBOOST.`) {
8989
return nil, fmt.Errorf("analyzer: model[%s] not supported", pr.estimator)
9090
}
9191
// We untar the XGBoost.{pr.trainedModel}.tar.gz and get three files.

0 commit comments

Comments
 (0)