Skip to content

SEC-1921: Fixes that SimpleGrantedAuthority can be compared with other GrantedAuthority impl. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SEC-1921: Fixes that SimpleGrantedAuthority can be compared with other GrantedAuthority impl. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ public boolean equals(Object obj) {
return true;
}

if (obj instanceof SimpleGrantedAuthority) {
return role.equals(((SimpleGrantedAuthority) obj).role);
if (obj instanceof GrantedAuthority) {
return role.equals(((GrantedAuthority) obj).getAuthority());
}

return false;
Expand Down
12 changes: 12 additions & 0 deletions ...rc/test/java/org/springframework/security/core/authority/SimpleGrantedAuthorityTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,17 @@ public void toStringReturnsAuthorityValue() {
SimpleGrantedAuthority auth = new SimpleGrantedAuthority("TEST");
assertEquals("TEST", auth.toString());
}

@Test
public void equalityWithGrantedAuthority() {
GrantedAuthority grantedAuthority = new GrantedAuthority() {
private static final long serialVersionUID = 1L;
public String getAuthority() {
return "ROLE_STATIC";
}
};
SimpleGrantedAuthority simpleGrantedAuthority = new SimpleGrantedAuthority("ROLE_STATIC");
Assert.assertTrue(simpleGrantedAuthority.equals(grantedAuthority));
}

}