Enable implicit usings (#224)

Author: lahma

build-support/nuke-build/Configuration.cs

@@ -1,6 +1,4 @@
-using System;
 using System.ComponentModel;
-using System.Linq;
 using Nuke.Common.Tooling;
 
 [TypeConverter(typeof(TypeConverter<Configuration>))]

src/Directory.Build.props

@@ -17,13 +17,13 @@
     <Company>SpringSource</Company>
     <Copyright>Copyright 2002-2021 Spring.NET Framework Team.</Copyright>
     <Trademark>Apache License, Version 2.0</Trademark>
-    
+
     <CommonLoggingVersion>3.4.1</CommonLoggingVersion>
 
     <Authors>SpringSource</Authors>
-	<PackageIcon>SpringSource_Leaves32x32.png</PackageIcon>
+    <PackageIcon>SpringSource_Leaves32x32.png</PackageIcon>
     <PackageIconUrl>https://springframework.net/images/SpringSource_Leaves32x32.png</PackageIconUrl>
-	<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
+    <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <PackageProjectUrl>https://www.springframework.net/</PackageProjectUrl>
     <PackageTags>Library</PackageTags>
 
@@ -45,27 +45,29 @@
     <LangVersion>latest</LangVersion>
     <TargetFullFrameworkVersion>net462</TargetFullFrameworkVersion>
 
+    <ImplicitUsings>enable</ImplicitUsings>
+
   </PropertyGroup>
-  
+
   <ItemGroup Condition="'$(SourceLinkEnabled)' != 'false'">
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
   </ItemGroup>
-  
+
   <ItemGroup>
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0" PrivateAssets="All" />
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0.1" PrivateAssets="All"/>
   </ItemGroup>
 
   <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
-	<DebugType>Full</DebugType>
+    <DebugType>Full</DebugType>
     <DefineConstants>$(DefineConstants);DEBUG_DYNAMIC;</DefineConstants>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
     <DefineConstants>TRACE;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
-  
+
   <ItemGroup>
     <None Include="..\..\SpringSource_Leaves32x32.png" Pack="true" Visible="false" PackagePath=""/>
-  </ItemGroup>  
+  </ItemGroup>
 
 </Project>

src/Spring/Spring.Aop/Aop/Config/AopNamespaceUtils.cs

@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using System.Xml;
 using Spring.Aop.Framework.AutoProxy;
 using Spring.Objects.Factory.Config;
@@ -38,48 +37,48 @@ namespace Spring.Aop.Config
     /// </summary>
     /// <author>Rob Harrop</author>
     /// <author>Juergen Hoeller</author>
-    /// <author>Mark Pollack (.NET)</author>
+    /// <author>Mark Pollack (.NET)</author>
     /// <author>Erich Eichinger (.NET)</author>
     public class AopNamespaceUtils
     {
         /// <summary>
         ///  The object name of the internally managed auto-proxy creator.
         /// </summary>
-        public static readonly string AUTO_PROXY_CREATOR_OBJECT_NAME = "Spring.Aop.Config.InternalAutoProxyCreator";
-
-        /// <summary>
-        /// The type of the APC that handles advisors with object role <see cref="ObjectRole.ROLE_INFRASTRUCTURE"/>.
-        /// </summary>
+        public static readonly string AUTO_PROXY_CREATOR_OBJECT_NAME = "Spring.Aop.Config.InternalAutoProxyCreator";
+
+        /// <summary>
+        /// The type of the APC that handles advisors with object role <see cref="ObjectRole.ROLE_INFRASTRUCTURE"/>.
+        /// </summary>
         private static readonly Type InfrastructureAutoProxyCreatorType = typeof(InfrastructureAdvisorAutoProxyCreator);
-       
+
         /// <summary>
         /// Registers the internal auto proxy creator if necessary.
         /// </summary>
         /// <param name="parserContext">The parser context.</param>
         /// <param name="sourceElement">The source element.</param>
         public static void RegisterAutoProxyCreatorIfNecessary(ParserContext parserContext, XmlElement sourceElement)
-        {
-            AssertUtils.ArgumentNotNull(parserContext, "parserContext");
-            IObjectDefinitionRegistry registry = parserContext.Registry;
+        {
+            AssertUtils.ArgumentNotNull(parserContext, "parserContext");
+            IObjectDefinitionRegistry registry = parserContext.Registry;
             RegisterAutoProxyCreatorIfNecessary(registry);
-        }
-
-        /// <summary>
-        /// Registers the internal auto proxy creator if necessary.
-        /// </summary>
-        public static void RegisterAutoProxyCreatorIfNecessary(IObjectDefinitionRegistry registry)
-        {
-            AssertUtils.ArgumentNotNull(registry, "registry");
-
-            if (!registry.ContainsObjectDefinition(AUTO_PROXY_CREATOR_OBJECT_NAME))
-            {
-                RootObjectDefinition objectDefinition = new RootObjectDefinition(InfrastructureAutoProxyCreatorType);
-                objectDefinition.Role = ObjectRole.ROLE_INFRASTRUCTURE;
-                objectDefinition.PropertyValues.Add("order", int.MaxValue);
-                registry.RegisterObjectDefinition(AUTO_PROXY_CREATOR_OBJECT_NAME, objectDefinition);
-            }
-        }
-
+        }
+
+        /// <summary>
+        /// Registers the internal auto proxy creator if necessary.
+        /// </summary>
+        public static void RegisterAutoProxyCreatorIfNecessary(IObjectDefinitionRegistry registry)
+        {
+            AssertUtils.ArgumentNotNull(registry, "registry");
+
+            if (!registry.ContainsObjectDefinition(AUTO_PROXY_CREATOR_OBJECT_NAME))
+            {
+                RootObjectDefinition objectDefinition = new RootObjectDefinition(InfrastructureAutoProxyCreatorType);
+                objectDefinition.Role = ObjectRole.ROLE_INFRASTRUCTURE;
+                objectDefinition.PropertyValues.Add("order", int.MaxValue);
+                registry.RegisterObjectDefinition(AUTO_PROXY_CREATOR_OBJECT_NAME, objectDefinition);
+            }
+        }
+
         /// <summary>
         /// Forces the auto proxy creator to use decorator proxy.
         /// </summary>

src/Spring/Spring.Aop/Aop/Framework/AbstractMethodInvocation.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using System.Collections;
 using System.Reflection;
 using System.Text;
@@ -293,7 +292,7 @@ InterceptorAndDynamicMethodMatcher dynamicMatcher
 		}
 
         /// <summary>
-        /// Retrieves a new <see cref="AopAlliance.Intercept.IMethodInvocation"/> instance 
+        /// Retrieves a new <see cref="AopAlliance.Intercept.IMethodInvocation"/> instance
         /// for the next Proceed method call.
         /// </summary>
         /// <param name="invocation">
@@ -318,7 +317,7 @@ protected abstract IMethodInvocation PrepareMethodInvocationForProceed(
         protected virtual void AssertJoinpoint()
         {
             AssertUtils.ArgumentNotNull(target, "target");
-//            if (this.method != null 
+//            if (this.method != null
 //                && !this.method.DeclaringType.IsAssignableFrom(target.GetType()))
 //            {
 //                // This means the target type doesn't implement the interface.
@@ -351,9 +350,9 @@ protected virtual void AssertJoinpoint()
 		/// <remarks>
 		/// <p>
 		/// <note type="implementnotes">
-		/// Does <b>not</b> invoke <see cref="System.Object.ToString()"/> on the 
+		/// Does <b>not</b> invoke <see cref="System.Object.ToString()"/> on the
 		/// <see cref="Spring.Aop.Framework.AbstractMethodInvocation.This"/> target
-		/// object, as that too may be proxied. 
+		/// object, as that too may be proxied.
 		/// </note>
 		/// </p>
 		/// </remarks>
@@ -377,4 +376,4 @@ public override string ToString()
 			return buffer.ToString();
 		}
 	}
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/AfterReturningAdviceAdapter.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using AopAlliance.Aop;
 using AopAlliance.Intercept;
 
@@ -77,4 +76,4 @@ public virtual IInterceptor GetInterceptor(IAdvisor advisor)
             return new AfterReturningAdviceInterceptor(advice);
         }
     }
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/AfterReturningAdviceInterceptor.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using AopAlliance.Intercept;
 using Spring.Util;
 
@@ -93,4 +92,4 @@ public object Invoke(IMethodInvocation invocation)
 			return returnValue;
 		}
 	}
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/BeforeAdviceAdapter.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using AopAlliance.Aop;
 using AopAlliance.Intercept;
 
@@ -77,4 +76,4 @@ public virtual IInterceptor GetInterceptor(IAdvisor advisor)
             return new MethodBeforeAdviceInterceptor(advice);
         }
     }
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/DefaultAdvisorAdapterRegistry.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,9 +20,6 @@
 
 #region Imports
 
-using System;
-using System.Collections.Generic;
-
 using AopAlliance.Aop;
 using AopAlliance.Intercept;
 using Spring.Aop.Support;
@@ -42,7 +39,7 @@ namespace Spring.Aop.Framework.Adapter
 	public class DefaultAdvisorAdapterRegistry : IAdvisorAdapterRegistry
 	{
         private readonly IList<IAdvisorAdapter> adapters = new List<IAdvisorAdapter>();
-		
+
         /// <summary>
         /// Creates a new instance of the
         /// <see cref="Spring.Aop.Framework.Adapter.DefaultAdvisorAdapterRegistry"/> class.
@@ -61,7 +58,7 @@ public DefaultAdvisorAdapterRegistry()
             RegisterAdvisorAdapter(new AfterReturningAdviceAdapter());
             RegisterAdvisorAdapter(new ThrowsAdviceAdapter());
         }
-		
+
         /// <summary>
         /// Returns an <see cref="Spring.Aop.IAdvisor"/> wrapping the supplied
         /// <paramref name="advice"/>.
@@ -71,7 +68,7 @@ public DefaultAdvisorAdapterRegistry()
         /// <see cref="Spring.Aop.IBeforeAdvice"/> or
         /// <see cref="Spring.Aop.IThrowsAdvice"/>.
         /// </param>
-        /// <returns> 
+        /// <returns>
         /// An <see cref="Spring.Aop.IAdvisor"/> wrapping the supplied
         /// <paramref name="advice"/>. Never returns <cref lang="null"/>. If
         /// the <paramref name="advice"/> parameter is an
@@ -151,4 +148,4 @@ public virtual void RegisterAdvisorAdapter(IAdvisorAdapter adapter)
 	        this.adapters.Add(adapter);
 	    }
 	}
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/GlobalAdvisorAdapterRegistry.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,8 +18,6 @@
 
 #endregion
 
-using System;
-
 namespace Spring.Aop.Framework.Adapter
 {
     /// <summary>
@@ -64,4 +62,4 @@ private GlobalAdvisorAdapterRegistry()
 
         #endregion
     }
-}
+}

src/Spring/Spring.Aop/Aop/Framework/Adapter/MethodBeforeAdviceInterceptor.cs

@@ -1,7 +1,7 @@
 #region License
 
 /*
- * Copyright © 2002-2011 the original author or authors.
+ * Copyright � 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
 
 #region Imports
 
-using System;
 using AopAlliance.Intercept;
 using Spring.Util;
 
@@ -89,4 +88,4 @@ public object Invoke(IMethodInvocation invocation)
             return invocation.Proceed();
         }
     }
-}
+}