Gh 4014 #8554
Closed
Gh 4014 #8554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#4014 Also fixes error log with text "... Never happens." * Introduce `completionTimeout` into a `ClientManager` abstraction and fix inappropriate usages of the `connectionTimeout` over there. * Deprecate the `disconnectCompletionTimeout` in favor of `completionTimeout` for consistency with other similar places.
Fixes spring-projects#4014 Update MqttAdapterTests.testDifferentQos JUnit test.
Author
|
I see that I ran into a partial conflict with somebody else who was also solving this issue... |
artembilan
added
the
status: duplicate
Member
|
Sorry, this has been fixed via #8552. Thank you for your effort any way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-4014: Fix inconsistent usage of MQTT timeouts
Fixes #4014
Also fixes error log with text "... Never happens."
Introduce
completionTimeoutinto aClientManagerabstractionand fix inappropriate usages of the
connectionTimeoutover there.Deprecate the
disconnectCompletionTimeoutin favor ofcompletionTimeoutfor consistency with other similar places.Update MqttAdapterTests.testDifferentQos JUnit test.
TODO: There is still a problematic JUnit test ClientManagerBackToBackTests.testV3ClientManagerReconnect. It passes when executed alone, but fails when executed together with other tests. It seems to me that there is some race condition or improper Spring context initialization. I am not able to sort this out. The test used to pass before this fix, but that was "a pass by an accident" as it logged the problematic exception "... Never happens" and then passed.