Skip to content

Commit a4ca5c0

Browse files
committed
Fix Nullability in the ZeroMqMessageProducer
* Remove redundant `@NonNull` from the `ConvertingBytesMessageMapper`
1 parent c6ac811 commit a4ca5c0

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

spring-integration-core/src/main/java/org/springframework/integration/mapping/ConvertingBytesMessageMapper.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.util.Arrays;
2121
import java.util.Map;
2222

23-
import org.jspecify.annotations.NonNull;
2423
import org.jspecify.annotations.Nullable;
2524

2625
import org.springframework.messaging.Message;
@@ -53,7 +52,6 @@ public ConvertingBytesMessageMapper(MessageConverter messageConverter) {
5352
}
5453

5554
@Override
56-
@NonNull
5755
public Message<?> toMessage(byte[] bytes, @Nullable Map<String, Object> headers) {
5856
MessageHeaders messageHeaders = null;
5957
if (headers != null) {
@@ -66,7 +64,6 @@ public Message<?> toMessage(byte[] bytes, @Nullable Map<String, Object> headers)
6664
}
6765

6866
@Override
69-
@NonNull
7067
public byte[] fromMessage(Message<?> message) {
7168
Object result = this.messageConverter.fromMessage(message, byte[].class);
7269
Assert.state(result != null, () -> "the '" + this.messageConverter + "' produced null for message: " + message);

spring-integration-zeromq/src/main/java/org/springframework/integration/zeromq/inbound/ZeroMqMessageProducer.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.Collections;
2222
import java.util.List;
2323
import java.util.Map;
24+
import java.util.Objects;
2425
import java.util.concurrent.atomic.AtomicInteger;
2526
import java.util.function.Consumer;
2627

@@ -89,8 +90,7 @@ public class ZeroMqMessageProducer extends MessageProducerSupport {
8990

9091
private boolean receiveRaw;
9192

92-
@Nullable
93-
private String connectUrl;
93+
private @Nullable String connectUrl;
9494

9595
@SuppressWarnings("NullAway.Init")
9696
private volatile Mono<ZMQ.Socket> socketMono;
@@ -120,7 +120,7 @@ public void setConsumeDelay(Duration consumeDelay) {
120120
}
121121

122122
/**
123-
* Provide an {@link InboundMessageMapper} to convert a consumed data into a message to produce.
123+
* Provide an {@link InboundMessageMapper} to convert consumed data into a message to produce.
124124
* Ignored when {@link #setReceiveRaw(boolean)} is {@code true}.
125125
* @param messageMapper the {@link InboundMessageMapper} to use.
126126
*/
@@ -131,7 +131,7 @@ public void setMessageMapper(InboundMessageMapper<byte[]> messageMapper) {
131131

132132
/**
133133
* Provide a {@link MessageConverter} (as an alternative to {@link #messageMapper})
134-
* for converting a consumed data into a message to produce.
134+
* for converting consumed data into a message to produce.
135135
* Ignored when {@link #setReceiveRaw(boolean)} is {@code true}.
136136
* @param messageConverter the {@link MessageConverter} to use.
137137
*/
@@ -140,7 +140,7 @@ public void setMessageConverter(MessageConverter messageConverter) {
140140
}
141141

142142
/**
143-
* Whether raw {@link ZMsg} is present as a payload of message to produce or
143+
* Whether raw {@link ZMsg} is present as a payload of a message to produce or
144144
* it is fully converted to a {@link Message} including {@link ZeroMqHeaders#TOPIC} header (if any).
145145
* @param receiveRaw to convert from {@link ZMsg} or not; defaults to convert.
146146
*/
@@ -169,7 +169,7 @@ public void setTopics(String... topics) {
169169
}
170170

171171
/**
172-
* Configure an URL for {@link org.zeromq.ZMQ.Socket#connect(String)}.
172+
* Configure a URL for {@link org.zeromq.ZMQ.Socket#connect(String)}.
173173
* Mutually exclusive with the {@link #setBindPort(int)}.
174174
* @param connectUrl the URL to connect ZeroMq socket to.
175175
*/
@@ -306,7 +306,7 @@ private Mono<Message<?>> convertMessage(Mono<ZMsg> msgMono) {
306306
ZFrame topicFrame = this.unwrapTopic ? msg.unwrap() : msg.pop();
307307
headers = Collections.singletonMap(ZeroMqHeaders.TOPIC, topicFrame.getString(ZMQ.CHARSET));
308308
}
309-
return this.messageMapper.toMessage(msg.getLast().getData(), headers); // NOSONAR
309+
return Objects.requireNonNull(this.messageMapper.toMessage(msg.getLast().getData(), headers));
310310
});
311311
}
312312

0 commit comments

Comments
 (0)