checkstyle HideUtilityClassConstructor

https://sonar.spring.io/issues/search#componentRoots=org.springframework.integration%3Aspring-integration|createdAt=2016-04-01T10%3A00%3A36%2B0000|sort=UPDATE_DATE|asc=false

Author: garyrussell

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/support/MappingUtils.java

@@ -32,6 +32,10 @@
  */
 public class MappingUtils {
 
+	private MappingUtils() {
+		super();
+	}
+
 	/**
 	 * Map an o.s.Message to an o.s.a.core.Message.
 	 * @param requestMessage the request message.

spring-integration-core/src/main/java/org/springframework/integration/mapping/support/JsonHeaders.java

@@ -25,10 +25,15 @@
  * entries from/to Message Headers and other adapter, e.g. AMQP.
  *
  * @author Artem Bilan
+ * @author Gary Russell
  * @since 3.0
  */
 public class JsonHeaders {
 
+	private JsonHeaders() {
+		super();
+	}
+
 	public static final String PREFIX = "json";
 
 	public static final String TYPE_ID = PREFIX + "__TypeId__";

spring-integration-core/src/main/java/org/springframework/integration/support/json/JacksonJsonUtils.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -28,6 +28,10 @@
  */
 public final class JacksonJsonUtils {
 
+	private JacksonJsonUtils() {
+		super();
+	}
+
 	private static final ClassLoader classLoader = JacksonJsonUtils.class.getClassLoader();
 
 	private static final boolean jackson2Present =

spring-integration-core/src/main/java/org/springframework/integration/support/json/JsonObjectMapperProvider.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -39,6 +39,10 @@ public final class JsonObjectMapperProvider {
 	private static final boolean boonPresent =
 			ClassUtils.isPresent("org.boon.json.ObjectMapper", classLoader);
 
+	private JsonObjectMapperProvider() {
+		super();
+	}
+
 	public static JsonObjectMapper<?, ?> newInstance() {
 		if (JacksonJsonUtils.isJackson2Present()) {
 			return new Jackson2JsonObjectMapper();

spring-integration-core/src/main/java/org/springframework/integration/support/utils/IntegrationUtils.java

@@ -49,6 +49,10 @@ public class IntegrationUtils {
 	 */
 	public static final boolean fatalWhenNoBeanFactory = Boolean.valueOf(System.getenv("SI_FATAL_WHEN_NO_BEANFACTORY"));
 
+	private IntegrationUtils() {
+		super();
+	}
+
 	/**
 	 * @param beanFactory BeanFactory for lookup, must not be null.
 	 * @return The {@link ConversionService} bean whose name is "integrationConversionService" if available.

spring-integration-core/src/test/java/org/springframework/integration/core/TimeBasedUUIDGenerator.java

@@ -29,52 +29,56 @@
 class TimeBasedUUIDGenerator {
 
 	private static final Logger logger = Logger.getLogger(TimeBasedUUIDGenerator.class.getName());
-	
+
 	public static final Object lock = new Object();
-	
+
 	private static boolean canNotDetermineMac = true;
 	private static long lastTime;
 	private static long clockSequence = 0;
 	private static final long macAddress = getMac();
 
+	private TimeBasedUUIDGenerator() {
+		super();
+	}
+
 	/**
-	 * Will generate unique time based UUID where the next UUID is 
+	 * Will generate unique time based UUID where the next UUID is
 	 * always greater then the previous.
 	 */
 	public final static UUID generateId() {
 		return generateIdFromTimestamp(System.currentTimeMillis());
 	}
-	
+
 	public final static UUID generateIdFromTimestamp(long currentTimeMillis){
 		long time;
-		
+
 		synchronized (lock) {
 			if (currentTimeMillis > lastTime) {
 				lastTime = currentTimeMillis;
 				clockSequence = 0;
-			} else  { 
-				++clockSequence; 
+			} else  {
+				++clockSequence;
 			}
 		}
-		
-	
+
+
 		time = currentTimeMillis;
-		
+
 		// low Time
 		time = currentTimeMillis << 32;
-		
+
 		// mid Time
 		time |= ((currentTimeMillis & 0xFFFF00000000L) >> 16);
 
 		// hi Time
 		time |= 0x1000 | ((currentTimeMillis >> 48) & 0x0FFF); // version 1
-		
-		long clock_seq_hi_and_reserved = clockSequence;  
-    	
-    	clock_seq_hi_and_reserved <<=48;	
-  
-    	long cls = 0 | clock_seq_hi_and_reserved;
-    	
+
+		long clock_seq_hi_and_reserved = clockSequence;
+
+		clock_seq_hi_and_reserved <<=48;
+
+		long cls = 0 | clock_seq_hi_and_reserved;
+
 		long lsb = cls | macAddress;
 		if (canNotDetermineMac){
 			logger.warning("UUID generation process was not able to determine your MAC address. Returning random UUID (non version 1 UUID)");
@@ -93,12 +97,12 @@ private static long getMac(){
 				byte[] mac = "01:23:45:67:89:ab".getBytes();
 				//Converts array of unsigned bytes to an long
 				if (mac != null) {
-					for (int i = 0; i < mac.length; i++) {					
+					for (int i = 0; i < mac.length; i++) {
 						macAddressAsLong <<= 8;
 						macAddressAsLong ^= (long)mac[i] & 0xFF;
 					}
 				}
-			} 
+			}
 			canNotDetermineMac = false;
 		} catch (Exception e) {
 			e.printStackTrace();

spring-integration-file/src/main/java/org/springframework/integration/file/locking/FileChannelCache.java

@@ -37,6 +37,10 @@ final class FileChannelCache {
 	private static ConcurrentMap<File, FileChannel> channelCache = new ConcurrentHashMap<File, FileChannel>();
 
 
+	private FileChannelCache() {
+		super();
+	}
+
 	/**
 	 * Try to get a lock for this file while guaranteeing that the same channel will be used for all file locks in this
 	 * VM. If the lock could not be acquired this method will return <code>null</code>.

spring-integration-gemfire/src/test/java/org/springframework/integration/gemfire/config/xml/ParserTestUtil.java

@@ -23,34 +23,42 @@
 
 /**
  * @author Dan Oxlade
+ * @author Gary Russell
  */
 class ParserTestUtil {
-    static ParserContext createFakeParserContext() {
-        return new ParserContext(new XmlReaderContext(thisClassAsResource(), new FailFastProblemReporter(), null, null, null, null), null);
-    }
-
-    static InputStreamResource thisClassAsResource() {
-        return new InputStreamResource(ParserTestUtil.class.getResourceAsStream(ParserTestUtil.class.getSimpleName() + ".class"));
-    }
-
-
-    static org.w3c.dom.Document loadXMLFrom(String xml)
-            throws org.xml.sax.SAXException, java.io.IOException {
-        return loadXMLFrom(new java.io.ByteArrayInputStream(xml.getBytes()));
-    }
-
-    static org.w3c.dom.Document loadXMLFrom(java.io.InputStream is)
-            throws org.xml.sax.SAXException, java.io.IOException {
-        javax.xml.parsers.DocumentBuilderFactory factory =
-                javax.xml.parsers.DocumentBuilderFactory.newInstance();
-        factory.setNamespaceAware(true);
-        javax.xml.parsers.DocumentBuilder builder = null;
-        try {
-            builder = factory.newDocumentBuilder();
-        } catch (javax.xml.parsers.ParserConfigurationException ex) {
-        }
-        org.w3c.dom.Document doc = builder.parse(is);
-        is.close();
-        return doc;
-    }
+
+	private ParserTestUtil() {
+		super();
+	}
+
+	static ParserContext createFakeParserContext() {
+		return new ParserContext(
+				new XmlReaderContext(thisClassAsResource(), new FailFastProblemReporter(), null, null, null, null),
+				null);
+	}
+
+	static InputStreamResource thisClassAsResource() {
+		return new InputStreamResource(
+				ParserTestUtil.class.getResourceAsStream(ParserTestUtil.class.getSimpleName() + ".class"));
+	}
+
+	static org.w3c.dom.Document loadXMLFrom(String xml) throws org.xml.sax.SAXException, java.io.IOException {
+		return loadXMLFrom(new java.io.ByteArrayInputStream(xml.getBytes()));
+	}
+
+	static org.w3c.dom.Document loadXMLFrom(java.io.InputStream is)
+			throws org.xml.sax.SAXException, java.io.IOException {
+		javax.xml.parsers.DocumentBuilderFactory factory = javax.xml.parsers.DocumentBuilderFactory.newInstance();
+		factory.setNamespaceAware(true);
+		javax.xml.parsers.DocumentBuilder builder = null;
+		try {
+			builder = factory.newDocumentBuilder();
+		}
+		catch (javax.xml.parsers.ParserConfigurationException ex) {
+		}
+		org.w3c.dom.Document doc = builder.parse(is);
+		is.close();
+		return doc;
+	}
+
 }

spring-integration-gemfire/src/test/java/org/springframework/integration/gemfire/fork/CacheServerProcess.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2013 the original author or authors.
+ * Copyright 2013-2016 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -32,12 +32,17 @@
  * @author David Turanski
  * @author Gunnar Hillert
  * @author Soby Chacko
+ * @author Gary Russell
  *
  * Runs as a standalone Java app.
  * Modified from SGF implementation for testing client/server CQ features
  */
 public class CacheServerProcess {
 
+	private CacheServerProcess() {
+		super();
+	}
+
 	public static void main(String[] args) throws Exception {
 
 		Properties props = new Properties();

spring-integration-gemfire/src/test/java/org/springframework/integration/gemfire/fork/ForkUtil.java

@@ -37,6 +37,10 @@ public class ForkUtil {
 
 	private static String TEMP_DIR = System.getProperty("java.io.tmpdir");
 
+	private ForkUtil() {
+		super();
+	}
+
 	public static OutputStream cloneJVM(String argument) {
 		String cp = System.getProperty("java.class.path");
 		String home = System.getProperty("java.home");