Revert PreparsedDocumentProvider in GraphQlSource

Author: jord1e

spring-graphql/src/main/java/org/springframework/graphql/execution/DefaultGraphQlSourceBuilder.java

@@ -29,7 +29,6 @@
 import graphql.GraphQL;
 import graphql.execution.instrumentation.ChainedInstrumentation;
 import graphql.execution.instrumentation.Instrumentation;
-import graphql.execution.preparsed.PreparsedDocumentProvider;
 import graphql.language.InterfaceTypeDefinition;
 import graphql.language.UnionTypeDefinition;
 import graphql.schema.GraphQLCodeRegistry;
@@ -46,7 +45,6 @@
 import graphql.schema.idl.WiringFactory;
 
 import org.springframework.core.io.Resource;
-import org.springframework.graphql.execution.preparsed.SpringNoOpPreparsedDocumentProvider;
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 
@@ -72,9 +70,6 @@ class DefaultGraphQlSourceBuilder implements GraphQlSource.Builder {
 
 	private final List<Instrumentation> instrumentations = new ArrayList<>();
 
-	@Nullable
-	private PreparsedDocumentProvider preparsedDocumentProvider;
-
 	@Nullable
 	private BiFunction<TypeDefinitionRegistry, RuntimeWiring, GraphQLSchema> schemaFactory;
 
@@ -99,12 +94,6 @@ public GraphQlSource.Builder defaultTypeResolver(TypeResolver typeResolver) {
 		return this;
 	}
 
-	@Override
-	public GraphQlSource.Builder preparsedDocumentProvider(PreparsedDocumentProvider preparsedDocumentProvider) {
-		this.preparsedDocumentProvider = preparsedDocumentProvider;
-		return this;
-	}
-
 	@Override
 	public GraphQlSource.Builder exceptionResolvers(List<DataFetcherExceptionResolver> resolvers) {
 		this.exceptionResolvers.addAll(resolvers);
@@ -159,12 +148,6 @@ public GraphQlSource build() {
 			builder = builder.instrumentation(new ChainedInstrumentation(this.instrumentations));
 		}
 
-		PreparsedDocumentProvider preparsedDocumentProvider = (this.preparsedDocumentProvider != null ?
-				this.preparsedDocumentProvider :
-				SpringNoOpPreparsedDocumentProvider.INSTANCE);
-
-		builder = builder.preparsedDocumentProvider(preparsedDocumentProvider);
-
 		this.graphQlConfigurers.accept(builder);
 		GraphQL graphQl = builder.build();
 

spring-graphql/src/main/java/org/springframework/graphql/execution/GraphQlSource.java

@@ -23,16 +23,13 @@
 
 import graphql.GraphQL;
 import graphql.execution.instrumentation.Instrumentation;
-import graphql.execution.preparsed.PreparsedDocumentProvider;
-import graphql.language.Document;
 import graphql.schema.GraphQLSchema;
 import graphql.schema.GraphQLTypeVisitor;
 import graphql.schema.TypeResolver;
 import graphql.schema.idl.RuntimeWiring;
 import graphql.schema.idl.TypeDefinitionRegistry;
 
 import org.springframework.core.io.Resource;
-import org.springframework.graphql.execution.preparsed.SpringNoOpPreparsedDocumentProvider;
 
 /**
  * Strategy to resolve the {@link GraphQL} instance to use.
@@ -112,22 +109,6 @@ interface Builder {
 		 */
 		Builder defaultTypeResolver(TypeResolver typeResolver);
 
-		/**
-		 * Configure the {@link PreparsedDocumentProvider} to use for GraphQL requests.
-		 * <p>
-		 * A {@code PreparsedDocumentProvider} can be used to cache and/or whitelist
-		 * {@link Document} instances for queries. Configuring a
-		 * {@code PreparsedDocumentProvider} gives you the ability to skip query parsing
-		 * and validation.
-		 * <p>
-		 * By default, this is set to {@link SpringNoOpPreparsedDocumentProvider}, which
-		 * calls the {@code parseAndValidateFunction}, and does nothing else.
-		 * @param preparsedDocumentProvider the {@code PreparsedDocumentProvider} to use
-		 * @return the current builder
-		 * @see GraphQL#getPreparsedDocumentProvider()
-		 */
-		Builder preparsedDocumentProvider(PreparsedDocumentProvider preparsedDocumentProvider);
-
 		/**
 		 * Add {@link DataFetcherExceptionResolver}'s to use for resolving exceptions from
 		 * {@link graphql.schema.DataFetcher}'s.

spring-graphql/src/main/java/org/springframework/graphql/execution/preparsed/SpringNoOpPreparsedDocumentProvider.java

@@ -21,7 +21,6 @@
 import java.util.List;
 
 import graphql.GraphQL;
-import graphql.execution.preparsed.PreparsedDocumentProvider;
 import graphql.schema.DataFetcher;
 import graphql.schema.GraphQLTypeVisitor;
 import graphql.schema.TypeResolver;
@@ -102,11 +101,6 @@ public GraphQlSetup typeResolver(TypeResolver typeResolver) {
 		return this;
 	}
 
-	public GraphQlSetup preparsedDocumentProvider(PreparsedDocumentProvider preparsedDocumentProvider) {
-		this.graphQlSourceBuilder.preparsedDocumentProvider(preparsedDocumentProvider);
-		return this;
-	}
-
 	public GraphQlSetup typeVisitor(GraphQLTypeVisitor... visitors) {
 		this.graphQlSourceBuilder.typeVisitors(Arrays.asList(visitors));
 		return this;