ReSTful URLs with content type extension do not work properly [SPR-5537]

[spring-projects-issues]

Eberhard Wolff opened SPR-5537 and commented

I have a controller like
@RequestMapping(value = "/customer/{id}", method = { RequestMethod.GET })
public ModelAndView getById(@PathVariable("id") int id) {
}

I do a GET to http://localhost:8080/customer/42.xml to get an XML representation. Result:

org.springframework.web.util.NestedServletException: Request

processing failed; nested exception is
org.springframework.beans.TypeMismatchException:
Failed to convert value of type [java.lang.String] to required type
[int];
nested exception is java.lang.NumberFormatException: For input string:
"42.xml"

i.e. the extension is considered part of the id and therefore it fails.

---

Affects: 3.0 M2

Issue Links:

• RESTful URLs with path variables containing dots are incorrectly mapped [SPR-6231] #10899 RESTful URLs with path variables containing dots are incorrectly mapped
• a Uri Value is incorrectly extracted if it contains '.'. [SPR-6164] #10832 a Uri Value is incorrectly extracted if it contains '.'.
• Extend Multiple @PathVariable Selection to allow delimeters other than / [SPR-5630] #10301 Extend Multiple @PathVariable Selection to allow delimeters other than /

Referenced from: commits c178888

1 votes, 1 watchers

[spring-projects-issues]

Alex Coles commented

This issues is bothering me too. I am working with a set of URLs that represent a date (similar to a nice SEO URLs that you might have in a blog use-case). Although I need to dig in a lot further, what I've found for cursory glance is the following:

@RequestMapping(value = "/{year}/{month}/{day}", method = RequestMethod.GET)

WORKS, but only for providing the default (usually) HTML representation.

I saw on the SpringSource blog the use of * wildcard with file extension:
@RequestMapping(value = "/{year}/{month}/{day}.*", method = RequestMethod.GET)
This doesn't work at all for me.

It appears -- again, without digging into this too much -- that using a @PathVariable at the end of the mapping causes issues with content negotiation.

Not having the mapping end with a @PathVariable, however, seems to make things work:
@RequestMapping(value = "/{year}/{month}/{day}/page", method = RequestMethod.GET)
works for me
http://localhost:8080/myapp/2008/10/10/page.html
http://localhost:8080/myapp/2008/10/10/page.xml