Skip to content

Commit e2aa880

Browse files
committed
Return null from MockServletContext.getMimeType for unknown type
ServletContext.getMimeType() returns `null` for unknown mime types; not `application/octet-stream`. Issue: SPR-14908
1 parent fd1db57 commit e2aa880

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

spring-test/src/main/java/org/springframework/mock/web/MockServletContext.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.springframework.http.MediaTypeFactory;
5151
import org.springframework.util.Assert;
5252
import org.springframework.util.ClassUtils;
53+
import org.springframework.util.MimeType;
5354
import org.springframework.util.ObjectUtils;
5455
import org.springframework.util.StringUtils;
5556
import org.springframework.web.util.WebUtils;
@@ -267,7 +268,9 @@ public String getMimeType(String filePath) {
267268
return this.mimeTypes.get(extension).toString();
268269
}
269270
else {
270-
return MediaTypeFactory.getMediaType(filePath).orElse(MediaType.APPLICATION_OCTET_STREAM).toString();
271+
return MediaTypeFactory.getMediaType(filePath).
272+
map(MimeType::toString)
273+
.orElse(null);
271274
}
272275
}
273276

spring-test/src/test/java/org/springframework/mock/web/MockServletContextTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ public void registerContextAndGetContext() {
8282
public void getMimeType() {
8383
assertEquals("text/html", sc.getMimeType("test.html"));
8484
assertEquals("image/gif", sc.getMimeType("test.gif"));
85+
assertNull(sc.getMimeType("test.foobar"));
8586
}
8687

8788
/**

spring-web/src/test/java/org/springframework/mock/web/test/MockServletContext.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.springframework.http.MediaTypeFactory;
5151
import org.springframework.util.Assert;
5252
import org.springframework.util.ClassUtils;
53+
import org.springframework.util.MimeType;
5354
import org.springframework.util.ObjectUtils;
5455
import org.springframework.util.StringUtils;
5556
import org.springframework.web.util.WebUtils;
@@ -266,7 +267,9 @@ public String getMimeType(String filePath) {
266267
return this.mimeTypes.get(extension).toString();
267268
}
268269
else {
269-
return MediaTypeFactory.getMediaType(filePath).orElse(MediaType.APPLICATION_OCTET_STREAM).toString();
270+
return MediaTypeFactory.getMediaType(filePath).
271+
map(MimeType::toString)
272+
.orElse(null);
270273
}
271274
}
272275

0 commit comments

Comments
 (0)