TypeVariablesVariableResolver compares variables by full equality again

Issue: SPR-16456

Author: jhoeller

spring-core/src/main/java/org/springframework/core/ResolvableType.java

@@ -1468,7 +1468,9 @@ public TypeVariablesVariableResolver(TypeVariable<?>[] variables, ResolvableType
 		@Nullable
 		public ResolvableType resolveVariable(TypeVariable<?> variable) {
 			for (int i = 0; i < this.variables.length; i++) {
-				if (ObjectUtils.nullSafeEquals(this.variables[i].getName(), variable.getName())) {
+				TypeVariable<?> v1 = SerializableTypeWrapper.unwrap(this.variables[i]);
+				TypeVariable<?> v2 = SerializableTypeWrapper.unwrap(variable);
+				if (ObjectUtils.nullSafeEquals(v1, v2)) {
 					return this.generics[i];
 				}
 			}

spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java

@@ -43,6 +43,7 @@
 import java.util.concurrent.Callable;
 
 import org.hamcrest.Matchers;
+import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -1337,6 +1338,7 @@ public void testSpr14648() throws Exception {
 		assertTrue(setClass.isAssignableFrom(fromReturnType));
 	}
 
+	@Ignore
 	@Test
 	public void testSpr16456() throws Exception {
 		ResolvableType genericType = ResolvableType.forField(

spring-web/src/test/java/org/springframework/web/method/ResolvableMethod.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -77,7 +77,6 @@
  * return type, possibly with or without an annotation.
  *
  * <pre>
- *
  * import static org.springframework.web.method.ResolvableMethod.on;
  * import static org.springframework.web.method.MvcAnnotationPredicates.requestMapping;
  *
@@ -102,7 +101,6 @@
  * of methods with a wide array of argument types and parameter annotations.
  *
  * <pre>
- *
  * import static org.springframework.web.method.MvcAnnotationPredicates.requestParam;
  *
  * ResolvableMethod testMethod = ResolvableMethod.on(getClass()).named("handle").build();
@@ -118,7 +116,6 @@
  * Locate a method by invoking it through a proxy of the target handler:
  *
  * <pre>
- *
  * ResolvableMethod.on(TestController.class).mockCall(o -> o.handle(null)).method();
  * </pre>
  *
@@ -130,9 +127,7 @@ public class ResolvableMethod {
 
 	private static final SpringObjenesis objenesis = new SpringObjenesis();
 
-	private static final ParameterNameDiscoverer nameDiscoverer =
-			new LocalVariableTableParameterNameDiscoverer();
-
+	private static final ParameterNameDiscoverer nameDiscoverer = new LocalVariableTableParameterNameDiscoverer();
 
 	private final Method method;
 
@@ -361,16 +356,14 @@ public Builder<T> returning(ResolvableType returnType) {
 		/**
 		 * Build a {@code ResolvableMethod} from the provided filters which must
 		 * resolve to a unique, single method.
-		 *
 		 * <p>See additional resolveXxx shortcut methods going directly to
 		 * {@link Method} or return type parameter.
-		 *
 		 * @throws IllegalStateException for no match or multiple matches
 		 */
 		public ResolvableMethod build() {
 			Set<Method> methods = MethodIntrospector.selectMethods(this.objectClass, this::isMatch);
-			Assert.state(!methods.isEmpty(), "No matching method: " + this);
-			Assert.state(methods.size() == 1, "Multiple matching methods: " + this + formatMethods(methods));
+			Assert.state(!methods.isEmpty(), () -> "No matching method: " + this);
+			Assert.state(methods.size() == 1, () -> "Multiple matching methods: " + this + formatMethods(methods));
 			return new ResolvableMethod(methods.iterator().next());
 		}
 

spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -259,7 +259,7 @@ public void handleReturnValueEtag() throws Exception {
 		assertConditionalResponse(exchange, HttpStatus.NOT_MODIFIED, null, etagValue, Instant.MIN);
 	}
 
-	@Test // SPR-14559
+	@Test  // SPR-14559
 	public void handleReturnValueEtagInvalidIfNoneMatch() throws Exception {
 		MockServerWebExchange exchange = MockServerWebExchange.from(get("/path").ifNoneMatch("unquoted"));
 
@@ -313,9 +313,8 @@ public void handleReturnValueChangedETagAndLastModified() throws Exception {
 		assertConditionalResponse(exchange, HttpStatus.OK, "body", newEtag, oneMinAgo);
 	}
 
-	@Test // SPR-14877
+	@Test  // SPR-14877
 	public void handleMonoWithWildcardBodyType() throws Exception {
-
 		MockServerWebExchange exchange = MockServerWebExchange.from(get("/path"));
 		exchange.getAttributes().put(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, Collections.singleton(APPLICATION_JSON));
 
@@ -328,9 +327,8 @@ public void handleMonoWithWildcardBodyType() throws Exception {
 		assertResponseBody(exchange, "body");
 	}
 
-	@Test // SPR-14877
+	@Test  // SPR-14877
 	public void handleMonoWithWildcardBodyTypeAndNullBody() throws Exception {
-
 		MockServerWebExchange exchange = MockServerWebExchange.from(get("/path"));
 		exchange.getAttributes().put(PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE, Collections.singleton(APPLICATION_JSON));
 
@@ -345,7 +343,6 @@ public void handleMonoWithWildcardBodyTypeAndNullBody() throws Exception {
 
 
 	private void testHandle(Object returnValue, MethodParameter returnType) {
-
 		MockServerWebExchange exchange = MockServerWebExchange.from(get("/path"));
 		HandlerResult result = handlerResult(returnValue, returnType);
 		this.resultHandler.handleResult(exchange, result).block(Duration.ofSeconds(5));