Skip to content

Commit bf7a975

Browse files
committed
Avoid using Java 8 ZoneId class
Issue: SPR-12594
1 parent b89e62e commit bf7a975

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import java.text.DateFormat;
2020
import java.text.SimpleDateFormat;
21-
import java.time.ZoneId;
2221
import java.util.HashMap;
2322
import java.util.LinkedHashMap;
2423
import java.util.LinkedList;
@@ -168,7 +167,7 @@ public Jackson2ObjectMapperBuilder timeZone(TimeZone timeZone) {
168167
* @since 4.1.5
169168
*/
170169
public Jackson2ObjectMapperBuilder timeZone(String zoneId) {
171-
this.timeZone = TimeZone.getTimeZone(ZoneId.of(zoneId));
170+
this.timeZone = TimeZone.getTimeZone(zoneId);
172171
return this;
173172
}
174173

spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
package org.springframework.http.converter.json;
1818

1919
import java.text.SimpleDateFormat;
20-
import java.time.ZoneId;
21-
import java.time.zone.ZoneRulesException;
2220
import java.util.Arrays;
2321
import java.util.Collections;
2422
import java.util.Date;
@@ -179,7 +177,7 @@ public void localeSetter() {
179177

180178
@Test
181179
public void timeZoneSetter() {
182-
TimeZone timeZone = TimeZone.getTimeZone(ZoneId.of("Europe/Paris"));
180+
TimeZone timeZone = TimeZone.getTimeZone("Europe/Paris");
183181
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().timeZone(timeZone).build();
184182
assertEquals(timeZone, objectMapper.getSerializationConfig().getTimeZone());
185183
assertEquals(timeZone, objectMapper.getDeserializationConfig().getTimeZone());
@@ -189,15 +187,18 @@ public void timeZoneSetter() {
189187
public void timeZoneStringSetter() {
190188
String zoneId = "Europe/Paris";
191189
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().timeZone(zoneId).build();
192-
TimeZone timeZone = TimeZone.getTimeZone(ZoneId.of(zoneId));
190+
TimeZone timeZone = TimeZone.getTimeZone(zoneId);
193191
assertEquals(timeZone, objectMapper.getSerializationConfig().getTimeZone());
194192
assertEquals(timeZone, objectMapper.getDeserializationConfig().getTimeZone());
195193
}
196194

197-
@Test(expected = ZoneRulesException.class)
195+
@Test
198196
public void wrongTimeZoneStringSetter() {
199197
String zoneId = "foo";
200-
Jackson2ObjectMapperBuilder.json().timeZone(zoneId).build();
198+
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().timeZone(zoneId).build();
199+
TimeZone timeZone = TimeZone.getTimeZone("GMT");
200+
assertEquals(timeZone, objectMapper.getSerializationConfig().getTimeZone());
201+
assertEquals(timeZone, objectMapper.getDeserializationConfig().getTimeZone());
201202
}
202203

203204
@Test

spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
package org.springframework.http.converter.json;
1818

1919
import java.text.SimpleDateFormat;
20-
import java.time.ZoneId;
21-
import java.time.zone.ZoneRulesException;
2220
import java.util.Arrays;
2321
import java.util.Collections;
2422
import java.util.Date;
@@ -176,7 +174,7 @@ public void localeSetter() {
176174

177175
@Test
178176
public void timeZoneSetter() {
179-
TimeZone timeZone = TimeZone.getTimeZone(ZoneId.of("Europe/Paris"));
177+
TimeZone timeZone = TimeZone.getTimeZone("Europe/Paris");
180178

181179
this.factory.setTimeZone(timeZone);
182180
this.factory.afterPropertiesSet();
@@ -192,17 +190,21 @@ public void timeZoneStringSetter() {
192190
this.factory.setTimeZone(zoneId);
193191
this.factory.afterPropertiesSet();
194192

195-
TimeZone timeZone = TimeZone.getTimeZone(ZoneId.of(zoneId));
193+
TimeZone timeZone = TimeZone.getTimeZone(zoneId);
196194
assertEquals(timeZone, this.factory.getObject().getSerializationConfig().getTimeZone());
197195
assertEquals(timeZone, this.factory.getObject().getDeserializationConfig().getTimeZone());
198196
}
199197

200-
@Test(expected = ZoneRulesException.class)
198+
@Test
201199
public void wrongTimeZoneStringSetter() {
202200
String zoneId = "foo";
203201

204202
this.factory.setTimeZone(zoneId);
205203
this.factory.afterPropertiesSet();
204+
205+
TimeZone timeZone = TimeZone.getTimeZone("GMT");
206+
assertEquals(timeZone, this.factory.getObject().getSerializationConfig().getTimeZone());
207+
assertEquals(timeZone, this.factory.getObject().getDeserializationConfig().getTimeZone());
206208
}
207209

208210
@Test

0 commit comments

Comments
 (0)