Skip to content

Commit 9f00eb6

Browse files
committed
Clean up warnings
1 parent 3c17178 commit 9f00eb6

File tree

19 files changed

+20
-13
lines changed

19 files changed

+20
-13
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/config/AutowiredPropertyMarker.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
* @see BeanDefinition#getPropertyValues()
3535
* @see org.springframework.beans.factory.support.BeanDefinitionBuilder#addAutowiredProperty
3636
*/
37+
@SuppressWarnings("serial")
3738
public final class AutowiredPropertyMarker implements Serializable {
3839

3940
/**

spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionReader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ public int loadBeanDefinitions(EncodedResource encodedResource) throws BeanDefin
244244
logger.trace("Loading Groovy bean definitions from " + encodedResource);
245245
}
246246

247+
@SuppressWarnings("serial")
247248
Closure beans = new Closure(this) {
248249
@Override
249250
public Object call(Object... args) {

spring-beans/src/main/java/org/springframework/beans/factory/support/BeanDefinitionOverrideException.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
* @see DefaultListableBeanFactory#setAllowBeanDefinitionOverriding
3131
* @see DefaultListableBeanFactory#registerBeanDefinition
3232
*/
33+
@SuppressWarnings("serial")
3334
public class BeanDefinitionOverrideException extends BeanDefinitionStoreException {
3435

3536
private final BeanDefinition beanDefinition;

spring-beans/src/test/java/org/springframework/beans/DirectFieldAccessorTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ protected DirectFieldAccessor createAccessor(Object target) {
4141
public void withShadowedField() {
4242
final StringBuilder sb = new StringBuilder();
4343

44-
@SuppressWarnings("serial")
4544
TestBean target = new TestBean() {
4645
@SuppressWarnings("unused")
4746
StringBuilder name = sb;

spring-beans/src/test/java/org/springframework/tests/sample/beans/Colour.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
* @author Rob Harrop
2121
* @author Juergen Hoeller
2222
*/
23-
@SuppressWarnings("serial")
2423
public class Colour {
2524

2625
public static final Colour RED = new Colour("RED");

spring-context/src/main/java/org/springframework/validation/beanvalidation/SpringValidatorAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public void validate(Object target, Errors errors, Object... validationHints) {
118118
}
119119
}
120120

121-
@SuppressWarnings("unchecked")
121+
@SuppressWarnings({ "unchecked", "rawtypes" })
122122
@Override
123123
public void validateValue(
124124
Class<?> targetType, String fieldName, @Nullable Object value, Errors errors, Object... validationHints) {

spring-context/src/test/java/org/springframework/aop/config/MethodLocatingFactoryBeanTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void testWhenTargetBeanClassCannotBeResolved() {
9595
}
9696

9797
@Test
98-
@SuppressWarnings("unchecked")
98+
@SuppressWarnings({ "unchecked", "rawtypes" })
9999
public void testSunnyDayPath() throws Exception {
100100
given(beanFactory.getType(BEAN_NAME)).willReturn((Class)String.class);
101101
factory.setTargetBeanName(BEAN_NAME);
@@ -110,7 +110,7 @@ public void testSunnyDayPath() throws Exception {
110110
}
111111

112112
@Test
113-
@SuppressWarnings("unchecked")
113+
@SuppressWarnings({ "unchecked", "rawtypes" })
114114
public void testWhereMethodCannotBeResolved() {
115115
given(beanFactory.getType(BEAN_NAME)).willReturn((Class)String.class);
116116
factory.setTargetBeanName(BEAN_NAME);

spring-context/src/test/java/org/springframework/context/annotation/ConfigurationClassPostProcessorTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,6 +1356,7 @@ public String toString() {
13561356
@Configuration
13571357
public static class RawFactoryMethodRepositoryConfiguration {
13581358

1359+
@SuppressWarnings("rawtypes") // intentionally a raw type
13591360
@Bean
13601361
public Repository stringRepo() {
13611362
return new Repository<String>() {

spring-context/src/test/java/org/springframework/context/annotation/PropertySourceAnnotationTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ static class ConfigWithResolvablePlaceholderAndFactoryBean {
305305

306306
@Inject Environment env;
307307

308+
@SuppressWarnings("rawtypes")
308309
@Bean
309310
public FactoryBean testBean() {
310311
final String name = env.getProperty("testbean.name");

spring-context/src/test/java/org/springframework/context/event/ApplicationContextEventTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,7 @@ public void onApplicationEvent(MyEvent event) {
578578
}
579579

580580

581+
@SuppressWarnings("rawtypes")
581582
public static class MyPayloadListener implements ApplicationListener<PayloadApplicationEvent> {
582583

583584
public final Set<Object> seenPayloads = new HashSet<>();

0 commit comments

Comments
 (0)