Skip to content

Commit 824cb9f

Browse files
committed
Polish MessageBuilder
1 parent 4574528 commit 824cb9f

18 files changed

+55
-59
lines changed

spring-messaging/src/main/java/org/springframework/messaging/core/DestinationResolvingMessageSendingOperations.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ public interface DestinationResolvingMessageSendingOperations<D> extends Message
2727

2828
<P> void send(String destinationName, Message<P> message) throws MessagingException;
2929

30-
<T> void convertAndSend(String destinationName, T message) throws MessagingException;
30+
<T> void convertAndSend(String destinationName, T payload) throws MessagingException;
3131

32-
<T> void convertAndSend(String destinationName, T message, MessagePostProcessor postProcessor)
32+
<T> void convertAndSend(String destinationName, T payload, MessagePostProcessor postProcessor)
3333
throws MessagingException;
3434

3535
}

spring-messaging/src/main/java/org/springframework/messaging/core/MessageSendingOperations.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ public interface MessageSendingOperations<D> {
2929

3030
<P> void send(D destination, Message<P> message) throws MessagingException;
3131

32-
<T> void convertAndSend(T message) throws MessagingException;
32+
<T> void convertAndSend(T payload) throws MessagingException;
3333

34-
<T> void convertAndSend(D destination, T message) throws MessagingException;
34+
<T> void convertAndSend(D destination, T payload) throws MessagingException;
3535

36-
<T> void convertAndSend(T message, MessagePostProcessor postProcessor) throws MessagingException;
36+
<T> void convertAndSend(T payload, MessagePostProcessor postProcessor) throws MessagingException;
3737

38-
<T> void convertAndSend(D destination, T message, MessagePostProcessor postProcessor) throws MessagingException;
38+
<T> void convertAndSend(D destination, T payload, MessagePostProcessor postProcessor) throws MessagingException;
3939

4040
}

spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* A specialization of {@link AbstractMessageSendingTemplate} that adds String-based
3030
* destinations as a message header.
3131
*
32-
* @author Mark Fisher
32+
* @author Rossen Stoyanchev
3333
* @since 4.0
3434
*/
3535
public class SimpMessagingTemplate extends AbstractMessageSendingTemplate<String>
@@ -104,7 +104,7 @@ protected void doSend(String destination, Message<?> message) {
104104
SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message);
105105
headers.setDestination(destination);
106106
headers.setMessageTypeIfNotSet(SimpMessageType.MESSAGE);
107-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
107+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
108108

109109
long timeout = this.sendTimeout;
110110
boolean sent = (timeout >= 0)

spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public SessionHeaderPostProcessor(String sessionId) {
123123
public Message<?> postProcessMessage(Message<?> message) {
124124
SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message);
125125
headers.setSessionId(this.sessionId);
126-
return MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
126+
return MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
127127
}
128128
}
129129

spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/support/SubscriptionMethodReturnValueHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public Message<?> postProcessMessage(Message<?> message) {
9999
headers.setSessionId(this.sessionId);
100100
headers.setSubscriptionId(this.subscriptionId);
101101
headers.setMessageTypeIfNotSet(SimpMessageType.MESSAGE);
102-
return MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
102+
return MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
103103
}
104104
}
105105
}

spring-messaging/src/main/java/org/springframework/messaging/simp/handler/AnnotationMethodMessageHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ private void handleMessageInternal(Message<?> message, Map<MappingInfo, HandlerM
325325

326326
try {
327327
headers.setDestination(lookupPath);
328-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
328+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
329329

330330
Object returnValue = invocableHandlerMethod.invoke(message);
331331

spring-messaging/src/main/java/org/springframework/messaging/simp/handler/SimpleBrokerMessageHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ else if (SimpMessageType.CONNECT.equals(messageType)) {
106106
replyHeaders.setSessionId(headers.getSessionId());
107107
replyHeaders.setHeader(SimpMessageHeaderAccessor.CONNECT_MESSAGE_HEADER, message);
108108

109-
Message<byte[]> connectAck = MessageBuilder.withPayloadAndHeaders(EMPTY_PAYLOAD, replyHeaders).build();
109+
Message<byte[]> connectAck = MessageBuilder.withPayload(EMPTY_PAYLOAD).setHeaders(replyHeaders).build();
110110
this.messageChannel.send(connectAck);
111111
}
112112
}
@@ -121,7 +121,7 @@ protected void sendMessageToSubscribers(String destination, Message<?> message)
121121
headers.setSubscriptionId(subscriptionId);
122122

123123
Object payload = message.getPayload();
124-
Message<?> clientMessage = MessageBuilder.withPayloadAndHeaders(payload, headers).build();
124+
Message<?> clientMessage = MessageBuilder.withPayload(payload).setHeaders(headers).build();
125125
try {
126126
this.messageChannel.send(clientMessage);
127127
}

spring-messaging/src/main/java/org/springframework/messaging/simp/handler/UserDestinationMessageHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public void handleMessage(Message<?> message) throws MessagingException {
131131

132132
String targetDestination = destinationParser.getTargetDestination(sessionId);
133133
headers.setDestination(targetDestination);
134-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
134+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
135135

136136
if (logger.isTraceEnabled()) {
137137
logger.trace("Sending message to resolved target destination " + targetDestination);

spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ protected void handleMessageInternal(Message<?> message) {
239239
sessionId = (sessionId == null) ? SystemStompRelaySession.ID : sessionId;
240240
headers.setSessionId(sessionId);
241241
headers.updateStompCommandAsClientMessage();
242-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
242+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
243243
}
244244

245245
if (sessionId == null) {
@@ -252,7 +252,7 @@ protected void handleMessageInternal(Message<?> message) {
252252
}
253253

254254
if (SimpMessageType.CONNECT.equals(messageType)) {
255-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
255+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
256256
StompRelaySession session = new StompRelaySession(sessionId);
257257
this.relaySessions.put(sessionId, session);
258258
session.connect(message);
@@ -359,7 +359,7 @@ private void readStompFrame(Message<byte[]> message) {
359359
}
360360

361361
headers.setSessionId(this.sessionId);
362-
message = MessageBuilder.withPayloadAndHeaders(message.getPayload(), headers).build();
362+
message = MessageBuilder.withPayload(message.getPayload()).setHeaders(headers).build();
363363
sendMessageToClient(message);
364364
}
365365

@@ -383,7 +383,7 @@ private void sendError(String errorText) {
383383
StompHeaderAccessor headers = StompHeaderAccessor.create(StompCommand.ERROR);
384384
headers.setSessionId(this.sessionId);
385385
headers.setMessage(errorText);
386-
Message<?> errorMessage = MessageBuilder.withPayloadAndHeaders(new byte[0], headers).build();
386+
Message<?> errorMessage = MessageBuilder.withPayload(new byte[0]).setHeaders(headers).build();
387387
sendMessageToClient(errorMessage);
388388
}
389389

@@ -516,7 +516,7 @@ public void connect() {
516516
headers.setLogin(systemLogin);
517517
headers.setPasscode(systemPasscode);
518518
headers.setHeartbeat(systemHeartbeatSendInterval, systemHeartbeatReceiveInterval);
519-
Message<?> connectMessage = MessageBuilder.withPayloadAndHeaders(new byte[0], headers).build();
519+
Message<?> connectMessage = MessageBuilder.withPayload(new byte[0]).setHeaders(headers).build();
520520
super.connect(connectMessage);
521521
}
522522

spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompDecoder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ public Message<byte[]> decode(ByteBuffer buffer) {
6060
MultiValueMap<String, String> headers = readHeaders(buffer);
6161
byte[] payload = readPayload(buffer, headers);
6262

63-
decodedMessage = MessageBuilder.withPayloadAndHeaders(payload,
63+
decodedMessage = MessageBuilder.withPayload(payload).setHeaders(
6464
StompHeaderAccessor.create(StompCommand.valueOf(command), headers)).build();
6565
}
6666
else {
67-
decodedMessage = MessageBuilder.withPayloadAndHeaders(HEARTBEAT_PAYLOAD,
67+
decodedMessage = MessageBuilder.withPayload(HEARTBEAT_PAYLOAD).setHeaders(
6868
StompHeaderAccessor.create(SimpMessageType.HEARTBEAT)).build();
6969
}
7070

0 commit comments

Comments
 (0)