Skip to content

Commit 6438209

Browse files
committed
Remove JDK 1.7 guards
1 parent 7396210 commit 6438209

File tree

3 files changed

+3
-33
lines changed

3 files changed

+3
-33
lines changed

spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketNamespaceUtils.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.web.socket.config;
1818

19-
import org.springframework.util.ClassUtils;
2019
import org.w3c.dom.Element;
2120

2221
import org.springframework.beans.factory.config.BeanDefinition;
@@ -32,8 +31,6 @@
3231
import org.springframework.web.socket.sockjs.transport.handler.DefaultSockJsService;
3332
import org.springframework.web.socket.sockjs.transport.handler.WebSocketTransportHandler;
3433

35-
import java.util.concurrent.ScheduledThreadPoolExecutor;
36-
3734
/**
3835
* Provides utility methods for parsing common WebSocket XML namespace elements.
3936
*
@@ -43,10 +40,6 @@
4340
*/
4441
class WebSocketNamespaceUtils {
4542

46-
// Check for setRemoveOnCancelPolicy method - available on JDK 7 and higher
47-
private static boolean hasRemoveOnCancelPolicyMethod = ClassUtils.hasMethod(
48-
ScheduledThreadPoolExecutor.class, "setRemoveOnCancelPolicy", boolean.class);
49-
5043

5144
public static RuntimeBeanReference registerHandshakeHandler(Element element, ParserContext parserContext, Object source) {
5245
RuntimeBeanReference handlerRef;
@@ -147,9 +140,7 @@ private static RuntimeBeanReference registerSockJsTaskScheduler(String scheduler
147140
taskSchedulerDef.setSource(source);
148141
taskSchedulerDef.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
149142
taskSchedulerDef.getPropertyValues().add("poolSize", Runtime.getRuntime().availableProcessors());
150-
if (hasRemoveOnCancelPolicyMethod) {
151-
taskSchedulerDef.getPropertyValues().add("removeOnCancelPolicy", true);
152-
}
143+
taskSchedulerDef.getPropertyValues().add("removeOnCancelPolicy", true);
153144
taskSchedulerDef.getPropertyValues().add("threadNamePrefix", schedulerName + "-");
154145
parserContext.getRegistry().registerBeanDefinition(schedulerName, taskSchedulerDef);
155146
parserContext.registerComponent(new BeanComponentDefinition(taskSchedulerDef, schedulerName));

spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebSocketConfigurationSupport.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,9 @@
1818

1919
import org.springframework.context.annotation.Bean;
2020
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
21-
import org.springframework.util.ClassUtils;
2221
import org.springframework.web.servlet.HandlerMapping;
2322
import org.springframework.web.servlet.handler.AbstractHandlerMapping;
2423

25-
import java.util.concurrent.ScheduledThreadPoolExecutor;
26-
2724
/**
2825
* Configuration support for WebSocket request handling.
2926
*
@@ -32,11 +29,6 @@
3229
*/
3330
public class WebSocketConfigurationSupport {
3431

35-
// Check for setRemoveOnCancelPolicy method - available on JDK 7 and higher
36-
private static boolean hasRemoveOnCancelPolicyMethod = ClassUtils.hasMethod(
37-
ScheduledThreadPoolExecutor.class, "setRemoveOnCancelPolicy", boolean.class);
38-
39-
4032
@Bean
4133
public HandlerMapping webSocketHandlerMapping() {
4234
ServletWebSocketHandlerRegistry registry = new ServletWebSocketHandlerRegistry(defaultSockJsTaskScheduler());
@@ -71,9 +63,7 @@ public ThreadPoolTaskScheduler defaultSockJsTaskScheduler() {
7163
ThreadPoolTaskScheduler scheduler = new ThreadPoolTaskScheduler();
7264
scheduler.setThreadNamePrefix("SockJS-");
7365
scheduler.setPoolSize(Runtime.getRuntime().availableProcessors());
74-
if (hasRemoveOnCancelPolicyMethod) {
75-
scheduler.setRemoveOnCancelPolicy(true);
76-
}
66+
scheduler.setRemoveOnCancelPolicy(true);
7767
return scheduler;
7868
}
7969

spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebSocketMessageBrokerConfigurationSupport.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,12 @@
1818

1919
import org.springframework.context.annotation.Bean;
2020
import org.springframework.messaging.simp.config.AbstractMessageBrokerConfiguration;
21-
import org.springframework.messaging.simp.config.MessageBrokerRegistry;
2221
import org.springframework.messaging.simp.user.UserSessionRegistry;
2322
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
24-
import org.springframework.util.ClassUtils;
2523
import org.springframework.web.servlet.HandlerMapping;
2624
import org.springframework.web.socket.WebSocketHandler;
2725
import org.springframework.web.socket.messaging.SubProtocolWebSocketHandler;
2826

29-
import java.util.concurrent.ScheduledThreadPoolExecutor;
30-
3127
/**
3228
* Extends {@link AbstractMessageBrokerConfiguration} and adds configuration for
3329
* receiving and responding to STOMP messages from WebSocket clients.
@@ -41,11 +37,6 @@
4137
*/
4238
public abstract class WebSocketMessageBrokerConfigurationSupport extends AbstractMessageBrokerConfiguration {
4339

44-
// Check for setRemoveOnCancelPolicy method - available on JDK 7 and higher
45-
private static boolean hasRemoveOnCancelPolicyMethod = ClassUtils.hasMethod(
46-
ScheduledThreadPoolExecutor.class, "setRemoveOnCancelPolicy", boolean.class);
47-
48-
4940
private WebSocketTransportRegistration transportRegistration;
5041

5142

@@ -105,9 +96,7 @@ protected void configureWebSocketTransport(WebSocketTransportRegistration regist
10596
public ThreadPoolTaskScheduler messageBrokerSockJsTaskScheduler() {
10697
ThreadPoolTaskScheduler scheduler = new ThreadPoolTaskScheduler();
10798
scheduler.setPoolSize(Runtime.getRuntime().availableProcessors());
108-
if (hasRemoveOnCancelPolicyMethod) {
109-
scheduler.setRemoveOnCancelPolicy(true);
110-
}
99+
scheduler.setRemoveOnCancelPolicy(true);
111100
scheduler.setThreadNamePrefix("MessageBrokerSockJS-");
112101
return scheduler;
113102
}

0 commit comments

Comments
 (0)