Fix concurrent test failure

Since ListenableFuture callbacks are invoked after the future is set,
we cannot rely on callbacks having taken place right after a call
to future.get(). This change adds a CountdownLatch to detect when
the callbacks were invoked.

Issue: SPR-12538

Author: rstoyanchev

spring-web/src/test/java/org/springframework/web/client/AsyncRestTemplateIntegrationTests.java

@@ -599,25 +599,20 @@ public void getAndInterceptResponse() throws Exception {
 		template.setInterceptors(Collections.singletonList(interceptor));
 		ListenableFuture<ResponseEntity<String>> future = template.getForEntity("/get", String.class);
 
-		ResponseEntity<String> response = future.get();
+		interceptor.latch.await(5, TimeUnit.SECONDS);
 		assertNotNull(interceptor.response);
 		assertEquals(HttpStatus.OK, interceptor.response.getStatusCode());
 		assertNull(interceptor.exception);
-		assertEquals(helloWorld, response.getBody());
+		assertEquals(helloWorld, future.get().getBody());
 	}
 
 	@Test
 	public void getAndInterceptError() throws Exception {
 		RequestInterceptor interceptor = new RequestInterceptor();
 		template.setInterceptors(Collections.singletonList(interceptor));
-		ListenableFuture<ResponseEntity<String>> future = template.getForEntity("/status/notfound", String.class);
+		template.getForEntity("/status/notfound", String.class);
 
-		try {
-			future.get();
-			fail("No exception thrown");
-		} catch (ExecutionException ex) {
-			// expected
-		}
+		interceptor.latch.await(5, TimeUnit.SECONDS);
 		assertNotNull(interceptor.response);
 		assertEquals(HttpStatus.NOT_FOUND, interceptor.response.getStatusCode());
 		assertNull(interceptor.exception);
@@ -632,6 +627,8 @@ private void waitTillDone(ListenableFuture<?> future) {
 
 	private static class RequestInterceptor implements AsyncClientHttpRequestInterceptor {
 
+		private final CountDownLatch latch = new CountDownLatch(1);
+
 		private volatile ClientHttpResponse response;
 
 		private volatile Throwable exception;
@@ -654,7 +651,15 @@ public URI getURI() {
 			};
 
 			ListenableFuture<ClientHttpResponse> future = execution.executeAsync(request, body);
-			future.addCallback(resp -> response = resp, ex -> exception = ex);
+			future.addCallback(
+					resp -> {
+						response = resp;
+						this.latch.countDown();
+					},
+					ex -> {
+						exception = ex;
+						this.latch.countDown();
+					});
 			return future;
 		}
 	}