Skip to content

Commit 5c62c86

Browse files
committed
Revert "Fix failing test"
This reverts commit c01f45f.
1 parent 4bf5a02 commit 5c62c86

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupport.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.web.servlet.config.annotation;
1818

1919
import java.util.ArrayList;
20-
import java.util.Collections;
2120
import java.util.HashMap;
2221
import java.util.List;
2322
import java.util.Map;
@@ -322,11 +321,8 @@ public HandlerMapping resourceHandlerMapping() {
322321
*/
323322
@Bean
324323
public ResourceUrlGenerator resourceUrlGenerator() {
325-
Map<String, ?> handlerMap = Collections.<String, Object>emptyMap();
326-
if (resourceHandlerMapping() instanceof SimpleUrlHandlerMapping) {
327-
handlerMap = ((SimpleUrlHandlerMapping) resourceHandlerMapping()).getUrlMap();
328-
}
329-
return new ResourceUrlGenerator(handlerMap);
324+
SimpleUrlHandlerMapping hm = (SimpleUrlHandlerMapping) resourceHandlerMapping();
325+
return new ResourceUrlGenerator(hm.getUrlMap());
330326
}
331327

332328
/**

spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceUrlFilterTests.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.web.servlet.resource;
1818

1919
import java.util.ArrayList;
20+
import java.util.Collections;
2021
import java.util.List;
2122

2223
import javax.servlet.ServletException;
@@ -25,6 +26,7 @@
2526
import javax.servlet.http.HttpServletResponse;
2627

2728
import org.junit.Test;
29+
import org.springframework.context.annotation.Bean;
2830
import org.springframework.context.annotation.Configuration;
2931
import org.springframework.mock.web.test.MockFilterChain;
3032
import org.springframework.mock.web.test.MockHttpServletRequest;
@@ -34,6 +36,7 @@
3436
import org.springframework.web.context.support.AnnotationConfigWebApplicationContext;
3537
import org.springframework.web.servlet.config.annotation.ResourceHandlerRegistry;
3638
import org.springframework.web.servlet.config.annotation.WebMvcConfigurationSupport;
39+
import org.springframework.web.servlet.handler.SimpleUrlHandlerMapping;
3740

3841
import static org.junit.Assert.*;
3942

@@ -117,7 +120,6 @@ private void initFilterChain(Class<?> configClass) throws ServletException {
117120
@Configuration
118121
static class WebConfig extends WebMvcConfigurationSupport {
119122

120-
121123
@Override
122124
public void addResourceHandlers(ResourceHandlerRegistry registry) {
123125

@@ -129,6 +131,14 @@ public void addResourceHandlers(ResourceHandlerRegistry registry) {
129131
.addResourceLocations("classpath:org/springframework/web/servlet/resource/test/")
130132
.setResourceResolvers(resourceResolvers);
131133
}
134+
135+
@Bean
136+
public ResourceUrlGenerator resourceUrlGenerator() {
137+
ResourceUrlGenerator generator = new ResourceUrlGenerator();
138+
SimpleUrlHandlerMapping handlerMapping = (SimpleUrlHandlerMapping) resourceHandlerMapping();
139+
generator.setResourceHandlerMappings(Collections.singletonList(handlerMapping));
140+
return generator;
141+
}
132142
}
133143

134144
private static class TestServlet extends HttpServlet {

0 commit comments

Comments
 (0)