Spring Cleaning in December

- Delete unused imports
- Delete unused code
- Clean up warnings

Author: sbrannen

spring-aspects/src/main/java/org/springframework/scheduling/aspectj/AbstractAsyncExecutionAspect.aj

@@ -24,9 +24,7 @@ import org.aspectj.lang.annotation.SuppressAjWarnings;
 import org.aspectj.lang.reflect.MethodSignature;
 
 import org.springframework.aop.interceptor.AsyncExecutionAspectSupport;
-import org.springframework.core.task.AsyncListenableTaskExecutor;
 import org.springframework.core.task.AsyncTaskExecutor;
-import org.springframework.util.concurrent.ListenableFuture;
 
 /**
  * Abstract aspect that routes selected methods asynchronously.

spring-beans/src/main/java/org/springframework/beans/factory/support/MethodOverrides.java

@@ -17,7 +17,6 @@
 package org.springframework.beans.factory.support;
 
 import java.lang.reflect.Method;
-import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.Set;
 

spring-context/src/main/java/org/springframework/format/datetime/standard/PeriodFormatter.java

@@ -17,7 +17,6 @@
 package org.springframework.format.datetime.standard;
 
 import java.text.ParseException;
-import java.time.Instant;
 import java.time.Period;
 import java.util.Locale;
 

spring-context/src/test/java/org/springframework/cache/config/ExpressionCachingIntegrationTests.java

@@ -92,6 +92,7 @@ private User(String id) {
 			this.id = id;
 		}
 
+		@SuppressWarnings("unused")
 		public String getId() {
 			return id;
 		}
@@ -104,6 +105,7 @@ private Order(String id) {
 			this.id = id;
 		}
 
+		@SuppressWarnings("unused")
 		public String getId() {
 			return id;
 		}

spring-context/src/test/java/org/springframework/context/event/AbstractApplicationEventListenerTests.java

@@ -117,13 +117,13 @@ public void onApplicationEvent(GenericTestEvent<String> event) {
 		}
 	}
 
+	@SuppressWarnings("rawtypes")
 	static class RawApplicationListener implements ApplicationListener {
 		@Override
 		public void onApplicationEvent(ApplicationEvent event) {
 		}
 	}
 
-	@SuppressWarnings("unused")
 	static class TestEvents {
 
 		public ApplicationEvent applicationEvent;

spring-core/src/main/java/org/springframework/core/convert/support/ObjectToObjectConverter.java

@@ -101,7 +101,7 @@ public Object convert(Object source, TypeDescriptor sourceType, TypeDescriptor t
 				}
 			}
 			else if (member instanceof Constructor) {
-				Constructor<?> ctor = (Constructor) member;
+				Constructor<?> ctor = (Constructor<?>) member;
 				return ctor.newInstance(source);
 			}
 		}
@@ -155,7 +155,7 @@ private static boolean isApplicable(Member member, Class<?> sourceClass) {
 					method.getParameterTypes()[0] == sourceClass);
 		}
 		else if (member instanceof Constructor) {
-			Constructor<?> ctor = (Constructor) member;
+			Constructor<?> ctor = (Constructor<?>) member;
 			return (ctor.getParameterTypes()[0] == sourceClass);
 		}
 		else {

spring-core/src/test/java/org/springframework/core/convert/support/DefaultConversionServiceTests.java

@@ -561,9 +561,9 @@ public ListWrapper convert(List source) {
 	}
 
 	@Test
-	@SuppressWarnings("unchecked")
+	@SuppressWarnings("rawtypes")
 	public void convertObjectToCollection() {
-		List<String> result = (List<String>) conversionService.convert(3L, List.class);
+		List result = conversionService.convert(3L, List.class);
 		assertEquals(1, result.size());
 		assertEquals(3L, result.get(0));
 	}

spring-core/src/test/java/org/springframework/util/xml/AbstractStaxHandlerTestCase.java

@@ -82,7 +82,7 @@ public void noNamespacePrefixes() throws Exception {
 
 	private static boolean wwwSpringframeworkOrgIsAccessible() {
 		try {
-			new Socket("www.springframework.org", 80);
+			new Socket("www.springframework.org", 80).close();
 		}
 		catch (Exception e) {
 			return false;

spring-jdbc/src/main/java/org/springframework/jdbc/support/lob/DefaultLobHandler.java

@@ -207,7 +207,6 @@ public Reader getClobAsCharacterStream(ResultSet rs, int columnIndex) throws SQL
 	}
 
 	@Override
-	@SuppressWarnings("resource")
 	public LobCreator getLobCreator() {
 		return (this.createTemporaryLob ? new TemporaryLobCreator() : new DefaultLobCreator());
 	}

spring-jms/src/test/java/org/springframework/jms/config/JmsListenerContainerFactoryIntegrationTests.java

@@ -17,7 +17,6 @@
 package org.springframework.jms.config;
 
 import java.lang.reflect.Method;
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 import javax.jms.JMSException;