Skip to content

Commit 4d3ade5

Browse files
committed
Merge pull request #667 from luckybomb/spr12356
* spr12356: Better use of key iterator
2 parents 6606933 + 2e5d752 commit 4d3ade5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/annotation/BeanFactoryAnnotationUtils.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,14 @@ else if (beanFactory.containsBean(qualifier)) {
7979
private static <T> T qualifiedBeanOfType(ConfigurableListableBeanFactory bf, Class<T> beanType, String qualifier) {
8080
Map<String, T> candidateBeans = BeanFactoryUtils.beansOfTypeIncludingAncestors(bf, beanType);
8181
T matchingBean = null;
82-
for (String beanName : candidateBeans.keySet()) {
82+
for (Map.Entry<String, T> entry : candidateBeans.entrySet()) {
83+
String beanName = entry.getKey();
8384
if (isQualifierMatch(qualifier, beanName, bf)) {
8485
if (matchingBean != null) {
8586
throw new NoSuchBeanDefinitionException(qualifier, "No unique " + beanType.getSimpleName() +
8687
" bean found for qualifier '" + qualifier + "'");
8788
}
88-
matchingBean = candidateBeans.get(beanName);
89+
matchingBean = entry.getValue();
8990
}
9091
}
9192
if (matchingBean != null) {

0 commit comments

Comments
 (0)