From c035a22fa213ce7c0ccff65651f46cf58e91f7b4 Mon Sep 17 00:00:00 2001 From: mikereiche Date: Tue, 3 Jan 2023 10:43:29 -0800 Subject: [PATCH] Use "= true" for TRUE() and "= false" for FALSE(). Closes #1627. --- .../data/couchbase/core/query/QueryCriteria.java | 6 +++--- .../data/couchbase/core/query/QueryCriteriaTests.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java b/src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java index bd6255258..241d11e9d 100644 --- a/src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java +++ b/src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java @@ -499,14 +499,14 @@ public QueryCriteria notIn(boolean ignoreCase, @Nullable Object... o) { public QueryCriteria TRUE() { // true/false are reserved, use TRUE/FALSE value = null; operator = null; - format = "%1$s"; // field = 1$, operator = 2$, value=$3, $4, ... + format = "%1$s = true"; // field = 1$, operator = 2$, value=$3, $4, ... return this; } public QueryCriteria FALSE() { value = null; - operator = "NOT"; - format = "not(%1$s)"; // field = 1$, operator = 2$, value=$3, $4, ... + operator = null; + format = "%1$s = false"; // field = 1$, operator = 2$, value=$3, $4, ... return this; } diff --git a/src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java b/src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java index 12b6545ea..131c5f6e1 100644 --- a/src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java +++ b/src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java @@ -261,13 +261,13 @@ void testNotIn() { @Test void testTrue() { QueryCriteria c = where(i("name")).TRUE(); - assertEquals("`name`", c.export()); + assertEquals("`name` = true", c.export()); } @Test void testFalse() { QueryCriteria c = where(i("name")).FALSE(); - assertEquals("not(`name`)", c.export()); + assertEquals("`name` = false", c.export()); } @Test