Editing pass for production-ready-features.adoc #10830
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made it more formal and corrected sentence errors.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: normal
type: documentation
wilkinsona
approved these changes
Nov 1, 2017
Member
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Spotted three things that I don't think are particularly contentious. I'll take care of them as part of merging this.
| TIP: Generated passwords are logged as the application starts. Search for '`Using default | ||
| security password`'. | ||
| TIP: Generated passwords are logged as the application starts. To find the password in | ||
| the console, search it for '`Using default security password`'. |
|
|
||
| Metrics will, by default, be generated with the name `http.client.requests`. The name | ||
| can be customized using the `spring.metrics.web.client.requests-metrics-name` property. | ||
| By deault, metrics are generated with the name, `http.client.requests`. The name |
| the application directory with the file name, `application.pid`). | ||
| * `EmbeddedServerPortFileWriter` creates a file (or files) containing the ports of the | ||
| embedded server (by default in the application directory with the file name | ||
| embedded server (by default, in the application directory with the file name, |
wilkinsona
pushed a commit
that referenced
this pull request
Nov 1, 2017
wilkinsona
added a commit
that referenced
this pull request
Nov 1, 2017
* gh-10830: Wrap production-ready-features.adoc at 90 characters Make editorial changes to production-ready-features.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it more formal and corrected sentence errors.