Skip to content

Updates prefix match in BufferCounterService #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Updates prefix match in BufferCounterService #10278

wants to merge 3 commits into from

Conversation

@venilnoronha
Copy link
Contributor

@venilnoronha venilnoronha commented Sep 13, 2017

This PR updates the prefix match in BufferCounterService. Fixes #10145.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 13, 2017
@wilkinsona
Copy link
Member

wilkinsona commented Sep 18, 2017

Thanks for the PR. Could you please consider also adding a test that verifies that the prefix is correct now?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Sep 18, 2017
@venilnoronha
Copy link
Contributor Author

venilnoronha commented Sep 20, 2017

Seems like BufferCounterService was dropped by introducing micrometer metrics.

@wilkinsona
Copy link
Member

wilkinsona commented Sep 20, 2017

Thanks

@wilkinsona wilkinsona added priority: normal type: bug A general bug and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Sep 20, 2017
@wilkinsona wilkinsona added this to the 1.5.8 milestone Sep 20, 2017
@wilkinsona wilkinsona mentioned this pull request Sep 20, 2017
Closed
@wilkinsona wilkinsona self-assigned this Sep 20, 2017
wilkinsona added a commit that referenced this pull request Sep 20, 2017
@wilkinsona
Polish "Align prefix match in BufferCounterService with DefaultCounte…
aca3095 
…rService"

See gh-10278
wilkinsona added a commit that referenced this pull request Sep 20, 2017
@wilkinsona
Merge pull request #10278 from Venil Noronha
2bf4287 
* gh-10278:
  Polish "Align prefix match in BufferCounterService with DefaultCounterService"
  Align prefix match in BufferCounterService with DefaultCounterService
@wilkinsona
Copy link
Member

wilkinsona commented Sep 20, 2017

Thanks again. I've merged the change and tests into 1.5.x. As you noted, the code in question has been replaced with Micrometer in master.

@venilnoronha
Copy link
Contributor Author

venilnoronha commented Sep 20, 2017

I see. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: bug A general bug

Projects

None yet

Milestone

1.5.8

Development

Successfully merging this pull request may close these issues.

BufferCounterService should check for the "counter." prefix like it is done in the DefaultCounterService

3 participants

@venilnoronha @wilkinsona @spring-projects-issues