Skip to content

BufferCounterService should check for the "counter." prefix like it is done in the DefaultCounterService #10145

@artembilan

Description

@artembilan

The DefaultCounterService has the code:

if (metricName.startsWith("counter.") || metricName.startsWith("meter.")) {
	return metricName;
}

Meanwhile BufferCounterService:

if (metricName.startsWith("counter") || metricName.startsWith("meter")) {
	return metricName;
}

That doesn't look consistent and breaks our project when we switch from Java 7 to Java 8. Just because we can't read spring.metrics.counter.* from the Redis properly any more.

See spring-attic/counter#3 for more info.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions