Skip to content

Commit edba364

Browse files
committed
Merge pull request #31443 from izeye
* pr/31443: Static-import Mockito.mock() Closes gh-31443
2 parents cf6da93 + aab59c5 commit edba364

13 files changed

+55
-58
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import io.micrometer.wavefront.WavefrontConfig;
2222
import io.micrometer.wavefront.WavefrontMeterRegistry;
2323
import org.junit.jupiter.api.Test;
24-
import org.mockito.Mockito;
2524

2625
import org.springframework.boot.autoconfigure.AutoConfigurations;
2726
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@@ -98,7 +97,7 @@ static class BaseConfiguration {
9897

9998
@Bean
10099
WavefrontSender customWavefrontSender() {
101-
return Mockito.mock(WavefrontSender.class);
100+
return mock(WavefrontSender.class);
102101
}
103102

104103
@Bean

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/observation/ObservationAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import io.micrometer.tracing.handler.TracingObservationHandler;
3737
import org.junit.jupiter.api.Test;
3838
import org.mockito.Answers;
39-
import org.mockito.Mockito;
4039

4140
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
4241
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -49,6 +48,7 @@
4948

5049
import static org.assertj.core.api.Assertions.assertThat;
5150
import static org.assertj.core.api.Assertions.assertThatThrownBy;
51+
import static org.mockito.Mockito.mock;
5252

5353
/**
5454
* Tests for {@link ObservationAutoConfiguration}.
@@ -290,7 +290,7 @@ MeterObservationHandler<Context> customMeterObservationHandler1(CalledHandlers c
290290

291291
private static class CustomTracingObservationHandler implements TracingObservationHandler<Context> {
292292

293-
private final Tracer tracer = Mockito.mock(Tracer.class, Answers.RETURNS_MOCKS);
293+
private final Tracer tracer = mock(Tracer.class, Answers.RETURNS_MOCKS);
294294

295295
private final String name;
296296

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfigurationTests.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import io.micrometer.tracing.brave.bridge.BraveTracer;
3535
import org.junit.jupiter.api.Test;
3636
import org.mockito.Answers;
37-
import org.mockito.Mockito;
3837

3938
import org.springframework.boot.autoconfigure.AutoConfigurations;
4039
import org.springframework.boot.test.context.FilteredClassLoader;
@@ -43,6 +42,7 @@
4342
import org.springframework.context.annotation.Configuration;
4443

4544
import static org.assertj.core.api.Assertions.assertThat;
45+
import static org.mockito.Mockito.mock;
4646

4747
/**
4848
* Tests for {@link BraveAutoConfiguration}.
@@ -157,43 +157,43 @@ private static class CustomBraveConfiguration {
157157

158158
@Bean
159159
Tracing customTracing() {
160-
return Mockito.mock(Tracing.class);
160+
return mock(Tracing.class);
161161
}
162162

163163
@Bean
164164
Tracer customTracer() {
165-
return Mockito.mock(Tracer.class);
165+
return mock(Tracer.class);
166166
}
167167

168168
@Bean
169169
CurrentTraceContext customCurrentTraceContext() {
170-
return Mockito.mock(CurrentTraceContext.class);
170+
return mock(CurrentTraceContext.class);
171171
}
172172

173173
@Bean
174174
Factory customFactory() {
175-
return Mockito.mock(Factory.class);
175+
return mock(Factory.class);
176176
}
177177

178178
@Bean
179179
Sampler customSampler() {
180-
return Mockito.mock(Sampler.class);
180+
return mock(Sampler.class);
181181
}
182182

183183
@Bean
184184
HttpTracing customHttpTracing() {
185-
return Mockito.mock(HttpTracing.class);
185+
return mock(HttpTracing.class);
186186
}
187187

188188
@Bean
189189
HttpServerHandler<HttpServerRequest, HttpServerResponse> customHttpServerHandler() {
190-
HttpTracing httpTracing = Mockito.mock(HttpTracing.class, Answers.RETURNS_MOCKS);
190+
HttpTracing httpTracing = mock(HttpTracing.class, Answers.RETURNS_MOCKS);
191191
return HttpServerHandler.create(httpTracing);
192192
}
193193

194194
@Bean
195195
HttpClientHandler<HttpClientRequest, HttpClientResponse> customHttpClientHandler() {
196-
HttpTracing httpTracing = Mockito.mock(HttpTracing.class, Answers.RETURNS_MOCKS);
196+
HttpTracing httpTracing = mock(HttpTracing.class, Answers.RETURNS_MOCKS);
197197
return HttpClientHandler.create(httpTracing);
198198
}
199199

@@ -204,22 +204,22 @@ private static class CustomMicrometerBraveConfiguration {
204204

205205
@Bean
206206
BraveTracer customBraveTracer() {
207-
return Mockito.mock(BraveTracer.class);
207+
return mock(BraveTracer.class);
208208
}
209209

210210
@Bean
211211
BraveBaggageManager customBraveBaggageManager() {
212-
return Mockito.mock(BraveBaggageManager.class);
212+
return mock(BraveBaggageManager.class);
213213
}
214214

215215
@Bean
216216
BraveHttpServerHandler customBraveHttpServerHandler() {
217-
return Mockito.mock(BraveHttpServerHandler.class);
217+
return mock(BraveHttpServerHandler.class);
218218
}
219219

220220
@Bean
221221
BraveHttpClientHandler customBraveHttpClientHandler() {
222-
return Mockito.mock(BraveHttpClientHandler.class);
222+
return mock(BraveHttpClientHandler.class);
223223
}
224224

225225
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfigurationTests.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import io.micrometer.tracing.http.HttpClientHandler;
2727
import io.micrometer.tracing.http.HttpServerHandler;
2828
import org.junit.jupiter.api.Test;
29-
import org.mockito.Mockito;
3029

3130
import org.springframework.boot.autoconfigure.AutoConfigurations;
3231
import org.springframework.boot.test.context.FilteredClassLoader;
@@ -35,6 +34,7 @@
3534
import org.springframework.context.annotation.Configuration;
3635

3736
import static org.assertj.core.api.Assertions.assertThat;
37+
import static org.mockito.Mockito.mock;
3838

3939
/**
4040
* Tests for {@link MicrometerTracingAutoConfiguration}.
@@ -133,7 +133,7 @@ private static class TracerConfiguration {
133133

134134
@Bean
135135
Tracer tracer() {
136-
return Mockito.mock(Tracer.class);
136+
return mock(Tracer.class);
137137
}
138138

139139
}
@@ -143,7 +143,7 @@ private static class HttpClientHandlerConfiguration {
143143

144144
@Bean
145145
HttpClientHandler httpClientHandler() {
146-
return Mockito.mock(HttpClientHandler.class);
146+
return mock(HttpClientHandler.class);
147147
}
148148

149149
}
@@ -153,7 +153,7 @@ private static class HttpServerHandlerConfiguration {
153153

154154
@Bean
155155
HttpServerHandler httpServerHandler() {
156-
return Mockito.mock(HttpServerHandler.class);
156+
return mock(HttpServerHandler.class);
157157
}
158158

159159
}
@@ -163,17 +163,17 @@ private static class CustomConfiguration {
163163

164164
@Bean
165165
DefaultTracingObservationHandler customDefaultTracingObservationHandler() {
166-
return Mockito.mock(DefaultTracingObservationHandler.class);
166+
return mock(DefaultTracingObservationHandler.class);
167167
}
168168

169169
@Bean
170170
HttpServerTracingObservationHandler customHttpServerTracingObservationHandler() {
171-
return Mockito.mock(HttpServerTracingObservationHandler.class);
171+
return mock(HttpServerTracingObservationHandler.class);
172172
}
173173

174174
@Bean
175175
HttpClientTracingObservationHandler customHttpClientTracingObservationHandler() {
176-
return Mockito.mock(HttpClientTracingObservationHandler.class);
176+
return mock(HttpClientTracingObservationHandler.class);
177177
}
178178

179179
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryConfigurationsMicrometerConfigurationTests.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import io.opentelemetry.api.trace.Tracer;
2626
import org.junit.jupiter.api.Test;
2727
import org.mockito.Answers;
28-
import org.mockito.Mockito;
2928

3029
import org.springframework.boot.actuate.autoconfigure.tracing.OpenTelemetryConfigurations.MicrometerConfiguration;
3130
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -35,6 +34,7 @@
3534
import org.springframework.context.annotation.Configuration;
3635

3736
import static org.assertj.core.api.Assertions.assertThat;
37+
import static org.mockito.Mockito.mock;
3838

3939
/**
4040
* Tests for {@link MicrometerConfiguration}.
@@ -104,27 +104,27 @@ private static class CustomConfiguration {
104104

105105
@Bean
106106
OtelTracer customOtelTracer() {
107-
return Mockito.mock(OtelTracer.class);
107+
return mock(OtelTracer.class);
108108
}
109109

110110
@Bean
111111
EventPublisher customEventPublisher() {
112-
return Mockito.mock(EventPublisher.class);
112+
return mock(EventPublisher.class);
113113
}
114114

115115
@Bean
116116
OtelCurrentTraceContext customOtelCurrentTraceContext() {
117-
return Mockito.mock(OtelCurrentTraceContext.class);
117+
return mock(OtelCurrentTraceContext.class);
118118
}
119119

120120
@Bean
121121
OtelHttpClientHandler customOtelHttpClientHandler() {
122-
return Mockito.mock(OtelHttpClientHandler.class);
122+
return mock(OtelHttpClientHandler.class);
123123
}
124124

125125
@Bean
126126
OtelHttpServerHandler customOtelHttpServerHandler() {
127-
return Mockito.mock(OtelHttpServerHandler.class);
127+
return mock(OtelHttpServerHandler.class);
128128
}
129129

130130
}
@@ -134,7 +134,7 @@ private static class TracerConfiguration {
134134

135135
@Bean
136136
Tracer tracer() {
137-
return Mockito.mock(Tracer.class);
137+
return mock(Tracer.class);
138138
}
139139

140140
}
@@ -144,7 +144,7 @@ private static class OpenTelemetryConfiguration {
144144

145145
@Bean
146146
OpenTelemetry openTelemetry() {
147-
return Mockito.mock(OpenTelemetry.class, Answers.RETURNS_MOCKS);
147+
return mock(OpenTelemetry.class, Answers.RETURNS_MOCKS);
148148
}
149149

150150
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryConfigurationsSdkConfigurationTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import io.opentelemetry.sdk.trace.SpanProcessor;
2323
import io.opentelemetry.sdk.trace.samplers.Sampler;
2424
import org.junit.jupiter.api.Test;
25-
import org.mockito.Mockito;
2625

2726
import org.springframework.boot.actuate.autoconfigure.tracing.OpenTelemetryConfigurations.SdkConfiguration;
2827
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -31,6 +30,7 @@
3130
import org.springframework.context.annotation.Bean;
3231

3332
import static org.assertj.core.api.Assertions.assertThat;
33+
import static org.mockito.Mockito.mock;
3434

3535
/**
3636
* Tests for {@link SdkConfiguration}.
@@ -84,7 +84,7 @@ private static class CustomBeans {
8484

8585
@Bean
8686
OpenTelemetry customOpenTelemetry() {
87-
return Mockito.mock(OpenTelemetry.class);
87+
return mock(OpenTelemetry.class);
8888
}
8989

9090
@Bean
@@ -94,17 +94,17 @@ SdkTracerProvider customSdkTracerProvider() {
9494

9595
@Bean
9696
ContextPropagators customContextPropagators() {
97-
return Mockito.mock(ContextPropagators.class);
97+
return mock(ContextPropagators.class);
9898
}
9999

100100
@Bean
101101
Sampler customSampler() {
102-
return Mockito.mock(Sampler.class);
102+
return mock(Sampler.class);
103103
}
104104

105105
@Bean
106106
SpanProcessor customSpanProcessor() {
107-
return Mockito.mock(SpanProcessor.class);
107+
return mock(SpanProcessor.class);
108108
}
109109

110110
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryConfigurationsTracerConfigurationTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import io.opentelemetry.api.OpenTelemetry;
2020
import io.opentelemetry.api.trace.Tracer;
2121
import org.junit.jupiter.api.Test;
22-
import org.mockito.Mockito;
2322

2423
import org.springframework.boot.actuate.autoconfigure.tracing.OpenTelemetryConfigurations.TracerConfiguration;
2524
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -29,6 +28,7 @@
2928
import org.springframework.context.annotation.Configuration;
3029

3130
import static org.assertj.core.api.Assertions.assertThat;
31+
import static org.mockito.Mockito.mock;
3232

3333
/**
3434
* Tests for {@link TracerConfiguration}.
@@ -71,7 +71,7 @@ private static class OpenTelemetryConfiguration {
7171

7272
@Bean
7373
OpenTelemetry openTelemetry() {
74-
return Mockito.mock(OpenTelemetry.class);
74+
return mock(OpenTelemetry.class);
7575
}
7676

7777
}
@@ -81,7 +81,7 @@ private static class CustomConfiguration {
8181

8282
@Bean
8383
Tracer customTracer() {
84-
return Mockito.mock(Tracer.class);
84+
return mock(Tracer.class);
8585
}
8686

8787
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/wavefront/WavefrontTracingAutoConfigurationTests.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import io.micrometer.tracing.reporter.wavefront.WavefrontOtelSpanHandler;
2626
import io.micrometer.tracing.reporter.wavefront.WavefrontSpanHandler;
2727
import org.junit.jupiter.api.Test;
28-
import org.mockito.Mockito;
2928

3029
import org.springframework.boot.autoconfigure.AutoConfigurations;
3130
import org.springframework.boot.test.context.FilteredClassLoader;
@@ -156,27 +155,27 @@ private static class CustomConfiguration {
156155

157156
@Bean
158157
ApplicationTags customApplicationTags() {
159-
return Mockito.mock(ApplicationTags.class);
158+
return mock(ApplicationTags.class);
160159
}
161160

162161
@Bean
163162
WavefrontSpanHandler customWavefrontSpanHandler() {
164-
return Mockito.mock(WavefrontSpanHandler.class);
163+
return mock(WavefrontSpanHandler.class);
165164
}
166165

167166
@Bean
168167
SpanMetrics customSpanMetrics() {
169-
return Mockito.mock(SpanMetrics.class);
168+
return mock(SpanMetrics.class);
170169
}
171170

172171
@Bean
173172
WavefrontBraveSpanHandler customWavefrontBraveSpanHandler() {
174-
return Mockito.mock(WavefrontBraveSpanHandler.class);
173+
return mock(WavefrontBraveSpanHandler.class);
175174
}
176175

177176
@Bean
178177
WavefrontOtelSpanHandler customWavefrontOtelSpanHandler() {
179-
return Mockito.mock(WavefrontOtelSpanHandler.class);
178+
return mock(WavefrontOtelSpanHandler.class);
180179
}
181180

182181
}

0 commit comments

Comments
 (0)