Skip to content

Commit b6166dc

Browse files
committed
Move Assume to spring-boot-test-support
Fixes gh-10866
1 parent 427d262 commit b6166dc

File tree

3 files changed

+12
-20
lines changed

3 files changed

+12
-20
lines changed

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnJavaTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525

2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnJava.Range;
2727
import org.springframework.boot.system.JavaVersion;
28-
import org.springframework.boot.test.Assume;
2928
import org.springframework.boot.test.context.HideClassesClassLoader;
3029
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
30+
import org.springframework.boot.testsupport.Assume;
3131
import org.springframework.context.annotation.Bean;
3232
import org.springframework.context.annotation.Configuration;
3333
import org.springframework.util.ReflectionUtils;
@@ -48,7 +48,7 @@ public class ConditionalOnJavaTests {
4848

4949
@Test
5050
public void doesNotMatchIfBetterVersionIsRequired() {
51-
Assume.javaVersion(JavaVersion.EIGHT);
51+
Assume.javaEight();
5252
this.contextRunner.withUserConfiguration(Java9Required.class)
5353
.run((context) -> assertThat(context).doesNotHaveBean(String.class));
5454
}
@@ -93,13 +93,13 @@ public void olderThanMessage() throws Exception {
9393

9494
@Test
9595
public void java8IsDetected() throws Exception {
96-
Assume.javaVersion(JavaVersion.EIGHT);
96+
Assume.javaEight();
9797
assertThat(getJavaVersion()).isEqualTo("1.8");
9898
}
9999

100100
@Test
101101
public void java8IsTheFallback() throws Exception {
102-
Assume.javaVersion(JavaVersion.EIGHT);
102+
Assume.javaEight();
103103
assertThat(getJavaVersion(Function.class, Files.class, ServiceLoader.class))
104104
.isEqualTo("1.8");
105105
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfigurationTests.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,11 @@
3636
import org.springframework.boot.jdbc.DataSourceBuilder;
3737
import org.springframework.boot.liquibase.CommonsLoggingLiquibaseLogger;
3838
import org.springframework.boot.liquibase.LiquibaseServiceLocatorApplicationListener;
39-
import org.springframework.boot.system.JavaVersion;
40-
import org.springframework.boot.test.Assume;
4139
import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
4240
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
4341
import org.springframework.boot.test.context.runner.ContextConsumer;
4442
import org.springframework.boot.test.rule.OutputCapture;
43+
import org.springframework.boot.testsupport.Assume;
4544
import org.springframework.context.annotation.Bean;
4645
import org.springframework.context.annotation.Configuration;
4746
import org.springframework.context.annotation.Primary;
@@ -114,7 +113,7 @@ public void changelogJson() {
114113

115114
@Test
116115
public void changelogSql() {
117-
Assume.javaVersion(JavaVersion.EIGHT);
116+
Assume.javaEight();
118117
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class)
119118
.withPropertyValues(
120119
"spring.liquibase.change-log:classpath:/db/changelog/db.changelog-override.sql")

spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/Assume.java renamed to spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/Assume.java

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,32 +14,25 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.test;
17+
package org.springframework.boot.testsupport;
1818

1919
import org.junit.AssumptionViolatedException;
2020

21-
import org.springframework.boot.system.JavaVersion;
21+
import org.springframework.util.ClassUtils;
2222

2323
/**
2424
* Provides utility methods that allow JUnit tests to {@link org.junit.Assume} certain
2525
* conditions hold {@code true}. If the assumption fails, it means the test should be
2626
* skipped.
2727
*
2828
* @author Stephane Nicoll
29-
* @since 2.0.0
3029
*/
3130
public abstract class Assume {
3231

33-
/**
34-
* Assume that the specified {@link JavaVersion} is the one currently available.
35-
* @param version the expected Java version
36-
* @throws AssumptionViolatedException if the assumption fails
37-
*/
38-
public static void javaVersion(JavaVersion version) {
39-
JavaVersion current = JavaVersion.getJavaVersion();
40-
org.junit.Assume.assumeTrue(
41-
String.format("This test should run on %s (got %s)", version, current),
42-
current == version);
32+
public static void javaEight() {
33+
if (ClassUtils.isPresent("java.security.cert.URICertStoreParameters", null)) {
34+
throw new AssumptionViolatedException("Assumed Java 8 but got Java 9");
35+
}
4336
}
4437

4538
}

0 commit comments

Comments
 (0)