Skip to content

Commit 551c08e

Browse files
committed
Update conditions for OAuth security config
Closes gh-11070
1 parent 50a3c2f commit 551c08e

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2WebSecurityConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
* @since 2.0.0
3535
*/
3636
@Configuration
37-
@ConditionalOnMissingBean(WebSecurityConfigurerAdapter.class)
3837
@ConditionalOnBean(ClientRegistrationRepository.class)
3938
class OAuth2WebSecurityConfiguration {
4039

@@ -46,7 +45,8 @@ public OAuth2AuthorizedClientService authorizedClientService(
4645
}
4746

4847
@Configuration
49-
static class OAuth2WebSecurityConfigurationAdapter
48+
@ConditionalOnMissingBean(WebSecurityConfigurerAdapter.class)
49+
static class OAuth2WebSecurityConfigurerAdapter
5050
extends WebSecurityConfigurerAdapter {
5151

5252
@Override

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2WebSecurityConfigurationTests.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,6 @@ public void securityConfigurerBacksOffWhenClientRegistrationBeanAbsent()
8181
.run((context) -> assertThat(getAuthCodeFilters(context)).isEmpty());
8282
}
8383

84-
@Test
85-
public void securityConfigurerBacksOffWhenOtherWebSecurityAdapterPresent()
86-
throws Exception {
87-
this.contextRunner
88-
.withUserConfiguration(TestWebSecurityConfigurerConfig.class,
89-
OAuth2WebSecurityConfiguration.class)
90-
.run((context) -> assertThat(getAuthCodeFilters(context)).isEmpty());
91-
}
92-
9384
@Test
9485
public void configurationRegistersAuthorizedClientServiceBean() throws Exception {
9586
this.contextRunner.withUserConfiguration(ClientRepositoryConfiguration.class,
@@ -103,6 +94,18 @@ public void configurationRegistersAuthorizedClientServiceBean() throws Exception
10394
});
10495
}
10596

97+
@Test
98+
public void securityConfigurerBacksOffWhenOtherWebSecurityAdapterPresent()
99+
throws Exception {
100+
this.contextRunner
101+
.withUserConfiguration(TestWebSecurityConfigurerConfig.class,
102+
OAuth2WebSecurityConfiguration.class)
103+
.run((context) -> {
104+
assertThat(getAuthCodeFilters(context)).isEmpty();
105+
assertThat(context).getBean(OAuth2AuthorizedClientService.class).isNotNull();
106+
});
107+
}
108+
106109
@Test
107110
public void authorizedClientServiceBeanIsConditionalOnMissingBean() throws Exception {
108111
this.contextRunner

0 commit comments

Comments
 (0)