Fix http status code when new loglevel is set

See gh-8798

Author: eddumelendez

spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/LoggersMvcEndpoint.java

@@ -22,7 +22,6 @@
 import org.springframework.boot.actuate.endpoint.LoggersEndpoint.LoggerLevels;
 import org.springframework.boot.context.properties.ConfigurationProperties;
 import org.springframework.boot.logging.LogLevel;
-import org.springframework.http.HttpEntity;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestBody;
@@ -33,6 +32,7 @@
  *
  * @author Ben Hale
  * @author Kazuki Shimizu
+ * @author Eddú Meléndez
  * @since 1.5.0
  */
 @ConfigurationProperties(prefix = "endpoints.loggers")
@@ -69,9 +69,14 @@ public Object set(@PathVariable String name,
 			return getDisabledResponse();
 		}
 		String level = configuration.get("configuredLevel");
-		LogLevel logLevel = level == null ? null : LogLevel.valueOf(level.toUpperCase());
-		this.delegate.setLogLevel(name, logLevel);
-		return HttpEntity.EMPTY;
+		try {
+			LogLevel logLevel = level == null ? null : LogLevel.valueOf(level.toUpperCase());
+			this.delegate.setLogLevel(name, logLevel);
+			return ResponseEntity.noContent().build();
+		}
+		catch (IllegalArgumentException ex) {
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 }

spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/mvc/LoggersMvcEndpointTests.java

@@ -64,6 +64,7 @@
  *
  * @author Ben Hale
  * @author Phillip Webb
+ * @author Eddú Meléndez
  */
 @RunWith(SpringRunner.class)
 @SpringBootTest
@@ -148,15 +149,15 @@ public void contentTypeForGetCanBeApplicationJson() throws Exception {
 	@Test
 	public void setLoggerUsingApplicationJsonShouldSetLogLevel() throws Exception {
 		this.mvc.perform(post("/loggers/ROOT").contentType(MediaType.APPLICATION_JSON)
-				.content("{\"configuredLevel\":\"debug\"}")).andExpect(status().isOk());
+				.content("{\"configuredLevel\":\"debug\"}")).andExpect(status().isNoContent());
 		verify(this.loggingSystem).setLogLevel("ROOT", LogLevel.DEBUG);
 	}
 
 	@Test
 	public void setLoggerUsingActuatorV1JsonShouldSetLogLevel() throws Exception {
 		this.mvc.perform(post("/loggers/ROOT")
 				.contentType(ActuatorMediaTypes.APPLICATION_ACTUATOR_V1_JSON)
-				.content("{\"configuredLevel\":\"debug\"}")).andExpect(status().isOk());
+				.content("{\"configuredLevel\":\"debug\"}")).andExpect(status().isNoContent());
 		verify(this.loggingSystem).setLogLevel("ROOT", LogLevel.DEBUG);
 	}
 
@@ -169,6 +170,14 @@ public void setLoggerWhenDisabledShouldReturnNotFound() throws Exception {
 		verifyZeroInteractions(this.loggingSystem);
 	}
 
+	@Test
+	public void setLoggerWithWrongLogLevel() throws Exception {
+		this.mvc.perform(post("/loggers/ROOT").contentType(MediaType.APPLICATION_JSON)
+				.content("{\"configuredLevel\":\"other\"}"))
+				.andExpect(status().is4xxClientError());
+		verifyZeroInteractions(this.loggingSystem);
+	}
+
 	@Configuration
 	@Import({ JacksonAutoConfiguration.class,
 			HttpMessageConvertersAutoConfiguration.class,