Skip to content

Commit 1add283

Browse files
lsq27fmbenhassine
authored andcommitted
Auto-detect the class/interface to be mocked
Issue #4426
1 parent 008e93a commit 1add283

File tree

83 files changed

+274
-274
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+274
-274
lines changed

spring-batch-core/src/test/java/org/springframework/batch/core/JobParametersBuilderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class JobParametersBuilderTests {
6161
@BeforeEach
6262
void initialize() {
6363
this.job = new SimpleJob("simpleJob");
64-
this.jobExplorer = mock(JobExplorer.class);
64+
this.jobExplorer = mock();
6565
this.jobInstanceList = new ArrayList<>(1);
6666
this.jobExecutionList = new ArrayList<>(1);
6767
this.parametersBuilder = new JobParametersBuilder(this.jobExplorer);

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/annotation/BatchRegistrarTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public static class JobConfigurationWithoutTransactionManager {
179179

180180
@Bean
181181
public DataSource dataSource() {
182-
return Mockito.mock(DataSource.class);
182+
return Mockito.mock();
183183
}
184184

185185
}
@@ -190,27 +190,27 @@ public static class JobConfigurationWithUserDefinedInfrastructureBeans {
190190

191191
@Bean
192192
public JobRepository jobRepository() {
193-
return Mockito.mock(JobRepository.class);
193+
return Mockito.mock();
194194
}
195195

196196
@Bean
197197
public JobExplorer jobExplorer() {
198-
return Mockito.mock(JobExplorer.class);
198+
return Mockito.mock();
199199
}
200200

201201
@Bean
202202
public JobLauncher jobLauncher() {
203-
return Mockito.mock(JobLauncher.class);
203+
return Mockito.mock();
204204
}
205205

206206
@Bean
207207
public JobRegistry jobRegistry() {
208-
return Mockito.mock(JobRegistry.class);
208+
return Mockito.mock();
209209
}
210210

211211
@Bean
212212
public JobOperator jobOperator() {
213-
return Mockito.mock(JobOperator.class);
213+
return Mockito.mock();
214214
}
215215

216216
}

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/support/AutomaticJobRegistrarTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ void testStartStopRunning() {
183183
@Test
184184
void testStartStopRunningWithCallback() {
185185

186-
Runnable callback = Mockito.mock(Runnable.class);
186+
Runnable callback = Mockito.mock();
187187
Resource[] jobPaths = new Resource[] {
188188
new ClassPathResource("org/springframework/batch/core/launch/support/2jobs.xml") };
189189
setUpApplicationContextFactories(jobPaths, null);

spring-batch-core/src/test/java/org/springframework/batch/core/explore/support/JobExplorerFactoryBeanTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ class JobExplorerFactoryBeanTests {
5454
void setUp() {
5555

5656
factory = new JobExplorerFactoryBean();
57-
DataSource dataSource = mock(DataSource.class);
58-
PlatformTransactionManager transactionManager = mock(PlatformTransactionManager.class);
57+
DataSource dataSource = mock();
58+
PlatformTransactionManager transactionManager = mock();
5959
factory.setDataSource(dataSource);
6060
factory.setTransactionManager(transactionManager);
6161
factory.setTablePrefix(tablePrefix);
@@ -73,7 +73,7 @@ void testDefaultJdbcOperations() throws Exception {
7373
@Test
7474
void testCustomJdbcOperations() throws Exception {
7575

76-
JdbcOperations customJdbcOperations = mock(JdbcOperations.class);
76+
JdbcOperations customJdbcOperations = mock();
7777
factory.setJdbcOperations(customJdbcOperations);
7878
factory.afterPropertiesSet();
7979
assertEquals(customJdbcOperations, ReflectionTestUtils.getField(factory, "jdbcOperations"));
@@ -111,7 +111,7 @@ void testCreateExplorer() throws Exception {
111111
@Test
112112
public void testCustomTransactionAttributesSource() throws Exception {
113113
// given
114-
TransactionAttributeSource transactionAttributeSource = Mockito.mock(TransactionAttributeSource.class);
114+
TransactionAttributeSource transactionAttributeSource = Mockito.mock();
115115
this.factory.setTransactionAttributeSource(transactionAttributeSource);
116116
this.factory.afterPropertiesSet();
117117

spring-batch-core/src/test/java/org/springframework/batch/core/explore/support/SimpleJobExplorerTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ class SimpleJobExplorerTests {
6565
@BeforeEach
6666
void setUp() {
6767

68-
jobExecutionDao = mock(JobExecutionDao.class);
69-
jobInstanceDao = mock(JobInstanceDao.class);
70-
stepExecutionDao = mock(StepExecutionDao.class);
71-
ecDao = mock(ExecutionContextDao.class);
68+
jobExecutionDao = mock();
69+
jobInstanceDao = mock();
70+
stepExecutionDao = mock();
71+
ecDao = mock();
7272

7373
jobExplorer = new SimpleJobExplorer(jobInstanceDao, jobExecutionDao, stepExecutionDao, ecDao);
7474

spring-batch-core/src/test/java/org/springframework/batch/core/job/CompositeJobParametersValidatorTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,15 @@ void testValidatorsCanNotBeEmpty() {
5252

5353
@Test
5454
void testDelegateIsInvoked() throws JobParametersInvalidException {
55-
JobParametersValidator validator = mock(JobParametersValidator.class);
55+
JobParametersValidator validator = mock();
5656
validator.validate(parameters);
5757
compositeJobParametersValidator.setValidators(Arrays.asList(validator));
5858
compositeJobParametersValidator.validate(parameters);
5959
}
6060

6161
@Test
6262
void testDelegatesAreInvoked() throws JobParametersInvalidException {
63-
JobParametersValidator validator = mock(JobParametersValidator.class);
63+
JobParametersValidator validator = mock();
6464
validator.validate(parameters);
6565
validator.validate(parameters);
6666
compositeJobParametersValidator.setValidators(Arrays.asList(validator, validator));

spring-batch-core/src/test/java/org/springframework/batch/core/job/SimpleJobTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ void testRestart() throws Exception {
416416
void testInterruptWithListener() {
417417
step1.setProcessException(new JobInterruptedException("job interrupted!"));
418418

419-
JobExecutionListener listener = mock(JobExecutionListener.class);
419+
JobExecutionListener listener = mock();
420420
listener.beforeJob(jobExecution);
421421
listener.afterJob(jobExecution);
422422

spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/support/state/SplitStateTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ class SplitStateTests {
4343
void testBasicHandling() throws Exception {
4444

4545
Collection<Flow> flows = new ArrayList<>();
46-
Flow flow1 = mock(Flow.class);
47-
Flow flow2 = mock(Flow.class);
46+
Flow flow1 = mock();
47+
Flow flow2 = mock();
4848
flows.add(flow1);
4949
flows.add(flow2);
5050

@@ -61,8 +61,8 @@ void testBasicHandling() throws Exception {
6161
@Test
6262
void testConcurrentHandling() throws Exception {
6363

64-
Flow flow1 = mock(Flow.class);
65-
Flow flow2 = mock(Flow.class);
64+
Flow flow1 = mock();
65+
Flow flow2 = mock();
6666

6767
SplitState state = new SplitState(Arrays.asList(flow1, flow2), "foo");
6868
state.setTaskExecutor(new SimpleAsyncTaskExecutor());

spring-batch-core/src/test/java/org/springframework/batch/core/launch/TaskExecutorJobLauncherTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void execute(JobExecution execution) {
7272
void setUp() {
7373

7474
jobLauncher = new TaskExecutorJobLauncher();
75-
jobRepository = mock(JobRepository.class);
75+
jobRepository = mock();
7676
jobLauncher.setJobRepository(jobRepository);
7777

7878
}
@@ -265,13 +265,13 @@ void testRunStepStatusStopping() {
265265

266266
private void testRestartStepExecutionInvalidStatus(BatchStatus status) throws Exception {
267267
String jobName = "test_job";
268-
JobRepository jobRepository = mock(JobRepository.class);
268+
JobRepository jobRepository = mock();
269269
JobParameters parameters = new JobParametersBuilder().addLong("runtime", System.currentTimeMillis())
270270
.toJobParameters();
271-
JobExecution jobExecution = mock(JobExecution.class);
272-
Job job = mock(Job.class);
273-
JobParametersValidator validator = mock(JobParametersValidator.class);
274-
StepExecution stepExecution = mock(StepExecution.class);
271+
JobExecution jobExecution = mock();
272+
Job job = mock();
273+
JobParametersValidator validator = mock();
274+
StepExecution stepExecution = mock();
275275

276276
when(job.getName()).thenReturn(jobName);
277277
when(job.isRestartable()).thenReturn(true);

spring-batch-core/src/test/java/org/springframework/batch/core/launch/support/DataFieldMaxValueJobParametersIncrementerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
*/
3232
class DataFieldMaxValueJobParametersIncrementerTests {
3333

34-
private final DataFieldMaxValueIncrementer incrementer = mock(DataFieldMaxValueIncrementer.class);
34+
private final DataFieldMaxValueIncrementer incrementer = mock();
3535

3636
@Test
3737
void testInvalidKey() {

0 commit comments

Comments
 (0)