Skip to content

Commit edb036d

Browse files
ielatifilayaperumalg
authored andcommitted
Fix OCI GenAI auto-configuration
Signed-off-by: Issam El-atif <[email protected]>
1 parent 4bd7d3e commit edb036d

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

auto-configurations/models/spring-ai-autoconfigure-model-oci-genai/src/main/java/org/springframework/ai/model/oci/genai/autoconfigure/OCIGenAiChatAutoConfiguration.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.springframework.ai.oci.cohere.OCICohereChatModel;
2626
import org.springframework.beans.factory.ObjectProvider;
2727
import org.springframework.boot.autoconfigure.AutoConfiguration;
28-
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2928
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
3029
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
3130
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
@@ -38,13 +37,13 @@
3837
*
3938
* @author Anders Swanson
4039
* @author Ilayaperumal Gopinathan
40+
* @author Issam El-atif
4141
*/
42-
@AutoConfiguration
42+
@AutoConfiguration(after = OCIGenAiInferenceClientAutoConfiguration.class)
4343
@ConditionalOnClass(OCICohereChatModel.class)
4444
@EnableConfigurationProperties(OCICohereChatModelProperties.class)
4545
@ConditionalOnProperty(name = SpringAIModelProperties.CHAT_MODEL, havingValue = SpringAIModels.OCI_GENAI,
4646
matchIfMissing = true)
47-
@ImportAutoConfiguration(OCIGenAiInferenceClientAutoConfiguration.class)
4847
public class OCIGenAiChatAutoConfiguration {
4948

5049
@Bean

auto-configurations/models/spring-ai-autoconfigure-model-oci-genai/src/main/java/org/springframework/ai/model/oci/genai/autoconfigure/OCIGenAiEmbeddingAutoConfiguration.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.springframework.ai.model.SpringAIModels;
2323
import org.springframework.ai.oci.OCIEmbeddingModel;
2424
import org.springframework.boot.autoconfigure.AutoConfiguration;
25-
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2726
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2827
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
@@ -35,13 +34,13 @@
3534
*
3635
* @author Anders Swanson
3736
* @author Ilayaperumal Gopinathan
37+
* @author Issam El-atif
3838
*/
39-
@AutoConfiguration
39+
@AutoConfiguration(after = OCIGenAiInferenceClientAutoConfiguration.class)
4040
@ConditionalOnClass(OCIEmbeddingModel.class)
4141
@EnableConfigurationProperties(OCIEmbeddingModelProperties.class)
4242
@ConditionalOnProperty(name = SpringAIModelProperties.EMBEDDING_MODEL, havingValue = SpringAIModels.OCI_GENAI,
4343
matchIfMissing = true)
44-
@ImportAutoConfiguration(OCIGenAiInferenceClientAutoConfiguration.class)
4544
public class OCIGenAiEmbeddingAutoConfiguration {
4645

4746
@Bean

auto-configurations/models/spring-ai-autoconfigure-model-oci-genai/src/test/java/org/springframework/ai/model/oci/genai/autoconfigure/OCIGenAIAutoConfigurationTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ void setProperties(@TempDir Path tempDir) throws Exception {
5656
"spring.ai.oci.genai.cohere.chat.options.frequencyPenalty=0.1",
5757
"spring.ai.oci.genai.cohere.chat.options.presencePenalty=0.2"
5858
// @formatter:on
59-
).withConfiguration(AutoConfigurations.of(OCIGenAiChatAutoConfiguration.class));
59+
)
60+
.withConfiguration(AutoConfigurations.of(OCIGenAiInferenceClientAutoConfiguration.class,
61+
OCIGenAiChatAutoConfiguration.class));
6062

6163
contextRunner.run(context -> {
6264
OCICohereChatModel chatModel = context.getBean(OCICohereChatModel.class);

auto-configurations/models/spring-ai-autoconfigure-model-oci-genai/src/test/java/org/springframework/ai/model/oci/genai/autoconfigure/OCIGenAiAutoConfigurationIT.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ public class OCIGenAiAutoConfigurationIT {
5252
"spring.ai.oci.genai.embedding.servingMode=on-demand",
5353
"spring.ai.oci.genai.embedding.model=cohere.embed-english-light-v2.0"
5454
// @formatter:on
55-
).withConfiguration(AutoConfigurations.of(OCIGenAiEmbeddingAutoConfiguration.class));
55+
)
56+
.withConfiguration(AutoConfigurations.of(OCIGenAiInferenceClientAutoConfiguration.class,
57+
OCIGenAiEmbeddingAutoConfiguration.class));
5658

5759
private final ApplicationContextRunner cohereChatContextRunner = new ApplicationContextRunner().withPropertyValues(
5860
// @formatter:off
@@ -62,7 +64,9 @@ public class OCIGenAiAutoConfigurationIT {
6264
"spring.ai.oci.genai.cohere.chat.options.servingMode=on-demand",
6365
"spring.ai.oci.genai.cohere.chat.options.model=" + this.CHAT_MODEL_ID
6466
// @formatter:on
65-
).withConfiguration(AutoConfigurations.of(OCIGenAiChatAutoConfiguration.class));
67+
)
68+
.withConfiguration(AutoConfigurations.of(OCIGenAiInferenceClientAutoConfiguration.class,
69+
OCIGenAiChatAutoConfiguration.class));
6670

6771
@Test
6872
void embeddings() {

0 commit comments

Comments
 (0)