From 8e0a4bac221f122e65f7bba3f0c0a6aca25fd136 Mon Sep 17 00:00:00 2001 From: Mateusz Poliwczak Date: Mon, 25 Aug 2025 16:47:40 +0200 Subject: [PATCH] Remove unchecked splunk restart in test_modular_input_kinds.py These do not seem to be necessary, install_app_from_collection internally handles restarting of splunk. Also other tests that call install_app_from_collection do not restart splunk before. --- tests/integration/test_modular_input_kinds.py | 4 ---- tests/testlib.py | 3 --- 2 files changed, 7 deletions(-) diff --git a/tests/integration/test_modular_input_kinds.py b/tests/integration/test_modular_input_kinds.py index 4b7bc0022..654a1112b 100755 --- a/tests/integration/test_modular_input_kinds.py +++ b/tests/integration/test_modular_input_kinds.py @@ -22,10 +22,6 @@ class ModularInputKindTestCase(testlib.SDKTestCase): - def setUp(self): - super().setUp() - self.uncheckedRestartSplunk() - @pytest.mark.app def test_list_arguments(self): self.install_app_from_collection("modular_inputs") diff --git a/tests/testlib.py b/tests/testlib.py index 57ab1f2da..4dfc463d8 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -221,9 +221,6 @@ def pathInApp(self, appName, pathComponents): appPath = separator.join([splunkHome, "etc", "apps", appName] + pathComponents) return appPath - def uncheckedRestartSplunk(self, timeout=240): - self.service.restart(timeout) - def restartSplunk(self, timeout=240): if self.service.restart_required: self.service.restart(timeout)